You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@sling.apache.org by ol...@apache.org on 2021/07/26 07:21:05 UTC

[sling-org-apache-sling-commons-messaging-mail] 10/23: [checkstyle] (modifier) RedundantModifier

This is an automated email from the ASF dual-hosted git repository.

olli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/sling-org-apache-sling-commons-messaging-mail.git

commit 2561508a552e4efa116117b1f1ba8f738d1f5419
Author: Oliver Lietz <ol...@apache.org>
AuthorDate: Sun Jul 18 21:20:13 2021 +0200

    [checkstyle] (modifier) RedundantModifier
---
 .../sling/commons/messaging/mail/internal/SimpleMailService.java      | 2 +-
 .../sling/commons/messaging/mail/internal/SimpleMessageBuilder.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMailService.java b/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMailService.java
index c9124a6..bc7d5e0 100644
--- a/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMailService.java
+++ b/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMailService.java
@@ -174,7 +174,7 @@ public final class SimpleMailService implements MailService {
             final ClassLoader tccl = Thread.currentThread().getContextClassLoader();
             Thread.currentThread().setContextClassLoader(this.getClass().getClassLoader());
             final String password = cryptoService.decrypt(configuration.password());
-            try (final Transport transport = session.getTransport(SMTPS_PROTOCOL)) {
+            try (Transport transport = session.getTransport(SMTPS_PROTOCOL)) {
                 final List<ConnectionListener> connectionListeners = this.connectionListeners;
                 connectionListeners.forEach(transport::addConnectionListener);
                 final List<TransportListener> transportListeners = this.transportListeners;
diff --git a/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMessageBuilder.java b/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMessageBuilder.java
index 6c7b7d2..62679cc 100644
--- a/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMessageBuilder.java
+++ b/src/main/java/org/apache/sling/commons/messaging/mail/internal/SimpleMessageBuilder.java
@@ -474,7 +474,7 @@ public final class SimpleMessageBuilder implements MessageBuilder {
 
     private static void addAttachments(final MimeMultipart parent, final List<Attachment> attachments) throws MessagingException {
         for (final Attachment attachment : attachments) {
-            try (final ByteArrayInputStream inputStream = new ByteArrayInputStream(attachment.content)) {
+            try (ByteArrayInputStream inputStream = new ByteArrayInputStream(attachment.content)) {
                 final MimeBodyPart part = new MimeBodyPart();
                 part.setDisposition(Part.ATTACHMENT);
                 part.setFileName(attachment.filename);
@@ -492,7 +492,7 @@ public final class SimpleMessageBuilder implements MessageBuilder {
 
     private static void addInlines(final MimeMultipart parent, final List<Inline> inlines) throws MessagingException {
         for (final Inline inline : inlines) {
-            try (final ByteArrayInputStream inputStream = new ByteArrayInputStream(inline.content)) {
+            try (ByteArrayInputStream inputStream = new ByteArrayInputStream(inline.content)) {
                 final MimeBodyPart part = new MimeBodyPart();
                 part.setDisposition(Part.INLINE);
                 part.setContentID(String.format("<%s>", inline.cid));