You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shixiaogang <gi...@git.apache.org> on 2017/02/22 09:34:28 UTC
[GitHub] flink pull request #3387: [FLINK-5863][queryable state] Add the serializatio...
GitHub user shixiaogang opened a pull request:
https://github.com/apache/flink/pull/3387
[FLINK-5863][queryable state] Add the serialization of list states in KvStateRequestSerializer
1. Add `serializeList()` in `KvStateRequestSerialization`
2. Modify the unit tests of `KvStateRequestSerialization`, without the access to protected methods.
3. Move `KvStateRequestSerializationRocksDBTest` from package `org.apache.flink.test.query` to `org.apache.flink.contrib.streaming.state`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/alibaba/flink flink-5863
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3387.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3387
----
commit 5fc51b5f233ec62e143c1938b11c677b2260575b
Author: xiaogang.sxg <xi...@alibaba-inc.com>
Date: 2017-02-22T03:56:24Z
Add the serialization of list states in KvStateRequestSerializer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3387: [FLINK-5863][queryable state] Add the serializatio...
Posted by shixiaogang <gi...@git.apache.org>.
Github user shixiaogang closed the pull request at:
https://github.com/apache/flink/pull/3387
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3387: [FLINK-5863][queryable state] Add the serialization of li...
Posted by shixiaogang <gi...@git.apache.org>.
Github user shixiaogang commented on the issue:
https://github.com/apache/flink/pull/3387
The PR is just some cleaning of the code. Now that we are planning to refactor the implementation, I agree to close the PR and I am very willing to contribute to the FLIP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3387: [FLINK-5863][queryable state] Add the serialization of li...
Posted by uce <gi...@git.apache.org>.
Github user uce commented on the issue:
https://github.com/apache/flink/pull/3387
If I understand this correctly, this gets rid of duplicated code. I think this is in general very valuable, but the problem is queryable state right now is that we need to refactor this for 1.3 anyways. Currently, too many `flink-runtime` components are exposed to the user. I'm working on a FLIP to improve the user APIs for 1.3 and deprecated (or maybe even remove) the current APIs. This will therefore become obsolete. What do you think? Should we close this PR and issue and you help on the proposed changes instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---