You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/19 10:05:44 UTC

[GitHub] [doris] liaoxin01 commented on a diff in pull request #11882: [feature-wip](unique-key-merge-on-write) unique key table with MOW supports update

liaoxin01 commented on code in PR #11882:
URL: https://github.com/apache/doris/pull/11882#discussion_r950030904


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/UpdateStmt.java:
##########
@@ -170,7 +169,7 @@ private void analyzeSetExprs(Analyzer analyzer) throws AnalysisException {
                 throw new AnalysisException("The left side of the set expr must be the column name");
             }
             lhs.analyze(analyzer);
-            if (((SlotRef) lhs).getColumn().getAggregationType() != AggregateType.REPLACE) {
+            if (((SlotRef) lhs).getColumn().isKey()) {

Review Comment:
   AggregateType of value column is NONE in unique table with merge on write. In order to be compatible with these two scenarios, `isKey` is used to determine whether it is value column or key column.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org