You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/30 17:09:02 UTC

[GitHub] [arrow] Crystrix opened a new pull request #12298: Support null type in product aggregation

Crystrix opened a new pull request #12298:
URL: https://github.com/apache/arrow/pull/12298


   The product of an empty array or min_count == 0 returns an int64 scalar of 1, otherwise return a null int64 scalar.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #12298:
URL: https://github.com/apache/arrow/pull/12298


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12298: Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025186966


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
   
   Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot commented on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670


   Benchmark runs are scheduled for baseline = ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender = d8f8c09622adad19cd054b220665b1313b52c15d. d8f8c09622adad19cd054b220665b1313b52c15d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5b7c0c9ae1847888fd39fabea8aec1e...8e0a9ef657784de2b9ef9f2221bbf6a1/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24e66e507a0244b8933c519b92c7f9a5...efb8911d0d8246b6a51e759646929992/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2e1bf268931f404d8a4a3c614278b0eb...f269d8e6c8134f0faeea0101e497096d/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025756294


   Thank you @Crystrix , will merge now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670


   Benchmark runs are scheduled for baseline = ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender = d8f8c09622adad19cd054b220665b1313b52c15d. d8f8c09622adad19cd054b220665b1313b52c15d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5b7c0c9ae1847888fd39fabea8aec1e...8e0a9ef657784de2b9ef9f2221bbf6a1/)
   [Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24e66e507a0244b8933c519b92c7f9a5...efb8911d0d8246b6a51e759646929992/)
   [Finished :arrow_down:1.17% :arrow_up:0.86%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2e1bf268931f404d8a4a3c614278b0eb...f269d8e6c8134f0faeea0101e497096d/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670


   Benchmark runs are scheduled for baseline = ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender = d8f8c09622adad19cd054b220665b1313b52c15d. d8f8c09622adad19cd054b220665b1313b52c15d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5b7c0c9ae1847888fd39fabea8aec1e...8e0a9ef657784de2b9ef9f2221bbf6a1/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24e66e507a0244b8933c519b92c7f9a5...efb8911d0d8246b6a51e759646929992/)
   [Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2e1bf268931f404d8a4a3c614278b0eb...f269d8e6c8134f0faeea0101e497096d/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025187165






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] ursabot edited a comment on pull request #12298: ARROW-15505: [C++][Compute] Support null type in product aggregation

Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12298:
URL: https://github.com/apache/arrow/pull/12298#issuecomment-1025759670


   Benchmark runs are scheduled for baseline = ad073b7c0fec80ce88aaf1e7d6a78104711952f2 and contender = d8f8c09622adad19cd054b220665b1313b52c15d. d8f8c09622adad19cd054b220665b1313b52c15d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e5b7c0c9ae1847888fd39fabea8aec1e...8e0a9ef657784de2b9ef9f2221bbf6a1/)
   [Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/24e66e507a0244b8933c519b92c7f9a5...efb8911d0d8246b6a51e759646929992/)
   [Finished :arrow_down:1.17% :arrow_up:0.86%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/2e1bf268931f404d8a4a3c614278b0eb...f269d8e6c8134f0faeea0101e497096d/)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org