You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "wxbty (via GitHub)" <gi...@apache.org> on 2023/05/19 13:55:34 UTC
[GitHub] [dubbo] wxbty opened a new pull request, #12357: serialization RpcException bug pr rebase
wxbty opened a new pull request, #12357:
URL: https://github.com/apache/dubbo/pull/12357
## What is the purpose of the change
rebase https://github.com/apache/dubbo/pull/12280 because of merged by branch 2.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1555745920
![Uploading image.png…]()
Please fix uts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12357: serialization RpcException bug pr rebase
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on code in PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#discussion_r1208976696
##########
dubbo-serialization/dubbo-serialization-api/src/main/java/org/apache/dubbo/common/serialize/DefaultSerializationExceptionWrapper.java:
##########
@@ -0,0 +1,365 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.dubbo.common.serialize;
+
+import org.apache.dubbo.common.URL;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import java.lang.reflect.Type;
+import java.util.Map;
+
+public class DefaultSerializationExceptionWrapper implements Serialization {
+
+ private final Serialization serialization;
+
+ public DefaultSerializationExceptionWrapper(Serialization serialization) {
+ if (serialization == null) {
+ throw new IllegalArgumentException("serialization == null");
+ }
+ this.serialization = serialization;
+ }
+
+ @Override
+ public byte getContentTypeId() {
+ return serialization.getContentTypeId();
+ }
+
+ @Override
+ public String getContentType() {
+ return serialization.getContentType();
+ }
+
+ @Override
+ public ObjectOutput serialize(URL url, OutputStream output) throws IOException {
+ ObjectOutput objectOutput = serialization.serialize(url, output);
+ return new ProxyObjectOutput(objectOutput);
+ }
+
+ @Override
+ public ObjectInput deserialize(URL url, InputStream input) throws IOException {
+ ObjectInput objectInput = serialization.deserialize(url, input);
+ return new ProxyObjectInput(objectInput);
+ }
+
+ static class ProxyObjectInput implements ObjectInput {
+
+ private final ObjectInput target;
+
+ public ProxyObjectInput(ObjectInput target) {
+ this.target = target;
+ }
+
+ @Override
+ public boolean readBool() throws IOException {
+ try {
+ return target.readBool();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public byte readByte() throws IOException {
+ try {
+ return target.readByte();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+
+ }
+ }
+
+ @Override
+ public short readShort() throws IOException {
+ try {
+ return target.readShort();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+
+ }
+ }
+
+ @Override
+ public int readInt() throws IOException {
+ try {
+ return target.readInt();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+
+ }
+ }
+
+ @Override
+ public long readLong() throws IOException {
+ try {
+ return target.readLong();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+
+ }
+ }
+
+ @Override
+ public float readFloat() throws IOException {
+ try {
+ return target.readFloat();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public double readDouble() throws IOException {
+ try {
+ return target.readDouble();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public String readUTF() throws IOException {
+ try {
+ return target.readUTF();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public byte[] readBytes() throws IOException {
+ try {
+ return target.readBytes();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public Object readObject() throws IOException, ClassNotFoundException {
+ try {
+ return target.readObject();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public <T> T readObject(Class<T> cls) throws IOException, ClassNotFoundException {
+ try {
+ return target.readObject(cls);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public <T> T readObject(Class<T> cls, Type type) throws IOException, ClassNotFoundException {
+ try {
+ return target.readObject(cls, type);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public Throwable readThrowable() throws IOException {
+ try {
+ return target.readThrowable();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public String readEvent() throws IOException {
+ try {
+ return target.readEvent();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public Map<String, Object> readAttachments() throws IOException, ClassNotFoundException {
+ try {
+ return target.readAttachments();
+ } catch (Exception e) {
+ Throwable t = handleToIOException(e);
+ if (e instanceof ClassNotFoundException) {
+ throw e;
+ }
+ throw (IOException) t;
+ }
+ }
+ }
+
+ static class ProxyObjectOutput implements ObjectOutput {
+
+ private final ObjectOutput target;
+
+ public ProxyObjectOutput(ObjectOutput target) {
+ this.target = target;
+ }
+
+ @Override
+ public void writeBool(boolean v) throws IOException {
+ try {
+ target.writeBool(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeByte(byte v) throws IOException {
+ try {
+ target.writeByte(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeShort(short v) throws IOException {
+ try {
+ target.writeShort(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeInt(int v) throws IOException {
+ try {
+ target.writeInt(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeLong(long v) throws IOException {
+ try {
+ target.writeLong(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeFloat(float v) throws IOException {
+ try {
+ target.writeFloat(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeDouble(double v) throws IOException {
+ try {
+ target.writeDouble(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeUTF(String v) throws IOException {
+ try {
+ target.writeUTF(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeBytes(byte[] v) throws IOException {
+ try {
+ target.writeBytes(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeBytes(byte[] v, int off, int len) throws IOException {
+ try {
+ target.writeBytes(v);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void flushBuffer() throws IOException {
+ try {
+ target.flushBuffer();
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeObject(Object obj) throws IOException {
+ try {
+ target.writeObject(obj);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeThrowable(Throwable obj) throws IOException {
+ try {
+ target.writeThrowable(obj);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeEvent(String data) throws IOException {
+ try {
+ target.writeEvent(data);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+
+ @Override
+ public void writeAttachments(Map<String, Object> attachments) throws IOException {
+ try {
+ target.writeAttachments(attachments);
+ } catch (Exception e) {
+ throw (IOException) handleToIOException(e);
+ }
+ }
+ }
+
+ private static Throwable handleToIOException(Exception e) {
+ Throwable t = e.getCause();
+ if (!(t instanceof IOException)) {
+ t = new IOException(new SerializationException(e));
+ }
+ return t;
+ }
Review Comment:
```suggestion
private static IOException handleToIOException(Exception e) {
if (!(e instanceof IOException)) {
return new IOException(new SerializationException(e));
}
return (IOException) e;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1556565658
> How about change it to judge IOException? Let's standardize all exceptions thrown under Serialzation into IOException, and then unify catch IOException to judge whether it is serialization. In otherwise, such transform will discard some real network exception.
PTAL again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1556440399
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [7 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [17.7% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1573337944
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [6.1% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ merged pull request #12357: serialization RpcException bug pr rebase
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ merged PR #12357:
URL: https://github.com/apache/dubbo/pull/12357
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1555863330
How about change it to judge IOException? Let's standardize all exceptions thrown under Serialzation into IOException, and then unify catch IOException to judge whether it is serialization. In otherwise, such transform will discard some real network exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1567084741
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [32 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [6.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1556218257
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [18.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] codecov-commenter commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1556219009
## [Codecov](https://app.codecov.io/gh/apache/dubbo/pull/12357?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#12357](https://app.codecov.io/gh/apache/dubbo/pull/12357?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dbf5fac) into [3.2](https://app.codecov.io/gh/apache/dubbo/commit/08727e8e270ce355a51417d9604dfd2954b6fe6b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (08727e8) will **increase** coverage by `0.64%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 3.2 #12357 +/- ##
============================================
+ Coverage 68.68% 69.32% +0.64%
+ Complexity 341 2 -339
============================================
Files 3569 1608 -1961
Lines 164820 66328 -98492
Branches 27335 9734 -17601
============================================
- Hits 113204 45983 -67221
+ Misses 41681 15881 -25800
+ Partials 9935 4464 -5471
```
[see 2002 files with indirect coverage changes](https://app.codecov.io/gh/apache/dubbo/pull/12357/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] AlbumenJ commented on a diff in pull request #12357: serialization RpcException bug pr rebase
Posted by "AlbumenJ (via GitHub)" <gi...@apache.org>.
AlbumenJ commented on code in PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#discussion_r1213993023
##########
dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedExchangeCodec.java:
##########
@@ -282,7 +282,7 @@ protected void encodeResponse(Channel channel, OutputStream os, Response res) th
logger.warn(TRANSPORT_FAILED_RESPONSE, "", "", "Fail to encode response: " + res + ", send bad_response info instead, cause: " + t.getMessage(), t);
Response r = new Response(res.getId(), res.getVersion());
- r.setStatus(Response.BAD_RESPONSE);
+ r.setStatus(Response.SERIALIZATION_ERROR);
Review Comment:
Check if `t` is instance of `IOException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1562254591
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [6.0% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1557217411
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [5 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [30.2% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] sonarcloud[bot] commented on pull request #12357: serialization RpcException bug pr rebase
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#issuecomment-1567090434
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_dubbo&pullRequest=12357)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_dubbo&pullRequest=12357&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL) [4 Code Smells](https://sonarcloud.io/project/issues?id=apache_dubbo&pullRequest=12357&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list) [6.1% Coverage](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_dubbo&pullRequest=12357&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo] wxbty commented on a diff in pull request #12357: serialization RpcException bug pr rebase
Posted by "wxbty (via GitHub)" <gi...@apache.org>.
wxbty commented on code in PR #12357:
URL: https://github.com/apache/dubbo/pull/12357#discussion_r1214018951
##########
dubbo-remoting/dubbo-remoting-api/src/test/java/org/apache/dubbo/remoting/codec/DeprecatedExchangeCodec.java:
##########
@@ -282,7 +282,7 @@ protected void encodeResponse(Channel channel, OutputStream os, Response res) th
logger.warn(TRANSPORT_FAILED_RESPONSE, "", "", "Fail to encode response: " + res + ", send bad_response info instead, cause: " + t.getMessage(), t);
Response r = new Response(res.getId(), res.getVersion());
- r.setStatus(Response.BAD_RESPONSE);
+ r.setStatus(Response.SERIALIZATION_ERROR);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org