You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/03/23 09:49:31 UTC
[GitHub] [skywalking-cli] wu-sheng commented on a change in pull request #138: Support eBPF profiling related commands
wu-sheng commented on a change in pull request #138:
URL: https://github.com/apache/skywalking-cli/pull/138#discussion_r833058928
##########
File path: cmd/swctl/main.go
##########
@@ -102,6 +103,7 @@ services, service instances, etc.`
alarm.Command,
layer.Command,
process.Command,
+ profiling.Command,
Review comment:
I would recommend you to make `profiling agent` and `profling ebpf` as 2 different sub commands.
This will be a breaking change, but it seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org