You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/03/15 23:50:47 UTC
Review Request: Fixed a bug in slave to only checkpoint framework pid if a
framework enabled checkpointing.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9970/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Description
-------
See summary.
Diffs
-----
src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
Diff: https://reviews.apache.org/r/9970/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request: Fixed a bug in slave to only checkpoint framework pid if
a framework enabled checkpointing.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9970/#review18014
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On March 15, 2013, 11:33 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9970/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 11:33 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
> src/tests/slave_recovery_tests.cpp 27911da0557408dfc35398beb68a548c0c27aca8
>
> Diff: https://reviews.apache.org/r/9970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request: Fixed a bug in slave to only checkpoint framework pid if
a framework enabled checkpointing.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9970/
-----------------------------------------------------------
(Updated March 15, 2013, 11:33 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
added a test.
Description
-------
See summary.
Diffs (updated)
-----
src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
src/tests/slave_recovery_tests.cpp 27911da0557408dfc35398beb68a548c0c27aca8
Diff: https://reviews.apache.org/r/9970/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request: Fixed a bug in slave to only checkpoint framework pid if
a framework enabled checkpointing.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9970/#review18003
-----------------------------------------------------------
Ship it!
And a test?
- Benjamin Hindman
On March 15, 2013, 10:50 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9970/
> -----------------------------------------------------------
>
> (Updated March 15, 2013, 10:50 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp 63956293cac304333acc87b60e834780a3d2489e
>
> Diff: https://reviews.apache.org/r/9970/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>