You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/23 03:11:27 UTC
[GitHub] [incubator-iotdb] wshao08 opened a new pull request #1245: Add test insertion interfaces for session and add primitiveArray pool config
wshao08 opened a new pull request #1245:
URL: https://github.com/apache/incubator-iotdb/pull/1245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1245: Add test insertion interfaces for session and add primitiveArray pool config
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #1245:
URL: https://github.com/apache/incubator-iotdb/pull/1245#discussion_r429516592
##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -207,6 +207,9 @@ chunk_buffer_pool_enable=false
# data.
# default_ttl=36000000
+# primitive array size (Byte) in array pool
Review comment:
```suggestion
# primitive array size (length of each array) in array pool
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] qiaojialin merged pull request #1245: Add test insertion interfaces for session and add primitiveArray pool config
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #1245:
URL: https://github.com/apache/incubator-iotdb/pull/1245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1245: Add test insertion interfaces for session and add primitiveArray pool config
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on a change in pull request #1245:
URL: https://github.com/apache/incubator-iotdb/pull/1245#discussion_r429515859
##########
File path: server/src/assembly/resources/conf/iotdb-engine.properties
##########
@@ -417,4 +417,7 @@ value_encoder=PLAIN
compressor=SNAPPY
# bloom filter error rate in TsFile
-bloom_filter_error_rate=0.05
\ No newline at end of file
+bloom_filter_error_rate=0.05
+
+# primitive array pool size in memory
Review comment:
array size, not pool size
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org