[GitHub] [helix] jiajunwang commented on a change in pull request #1537: fix two flaky test -- TestP2PNoDuplicatedMessage and TestDeleteJobFromJobQueue

[GitBox <gi...@apache.org>]

jiajunwang commented on a change in pull request #1537:
URL: https://github.com/apache/helix/pull/1537#discussion_r525400308



##########
File path: helix-core/src/test/java/org/apache/helix/integration/messaging/TestP2PNoDuplicatedMessage.java
##########
@@ -174,7 +174,10 @@ public void testP2PStateTransitionEnabled() {
       verifyP2PEnabled(startTime);
     }
 
-    Assert.assertEquals(p2pTrigged, total);
+    // The success rate really depends on how quick participant act in relationship with controller.
+    // For now, we set 90% threshold.
+    long threshold = Math.round(total * 0.9);

Review comment:
       @zhangmeng916 and @lei-xia , could you please confirm if this is the expectation? I understand that Kai needs to change it since the current run does not always succeed with 100% threshold. But I'm not sure if this should be our expectation?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org