You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sqoop.apache.org by Venkat Ranganathan <n....@live.com> on 2013/07/03 21:37:39 UTC

Review Request 12255: Fix for SQOOP-1113

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12255/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-1113
    https://issues.apache.org/jira/browse/SQOOP-1113


Repository: sqoop-sqoop2


Description
-------

Fix for text partitioning issue.  I also added a new test to test this case. 


Diffs
-----

  connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 0bb979e 
  connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java 1a3601a 

Diff: https://reviews.apache.org/r/12255/diff/


Testing
-------

Added a new test.   All tests pass


Thanks,

Venkat Ranganathan

Re: Review Request 12255: Fix for SQOOP-1113

Posted by Jarek Cecho <ja...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12255/#review22742
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On July 3, 2013, 7:37 p.m., Venkat Ranganathan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12255/
> -----------------------------------------------------------
> 
> (Updated July 3, 2013, 7:37 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-1113
>     https://issues.apache.org/jira/browse/SQOOP-1113
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Fix for text partitioning issue.  I also added a new test to test this case. 
> 
> 
> Diffs
> -----
> 
>   connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java 0bb979e 
>   connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java 1a3601a 
> 
> Diff: https://reviews.apache.org/r/12255/diff/
> 
> 
> Testing
> -------
> 
> Added a new test.   All tests pass
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>