[GitHub] [pinot] jackjlli commented on a change in pull request #7438: set ZK stat version when fetching segment ZK metadata

[GitBox <gi...@apache.org>]

jackjlli commented on a change in pull request #7438:
URL: https://github.com/apache/pinot/pull/7438#discussion_r711345389



##########
File path: pinot-common/src/main/java/org/apache/pinot/common/metadata/segment/SegmentZKMetadata.java
##########
@@ -123,6 +123,14 @@ public void setIndexVersion(String indexVersion) {
     setValue(Segment.INDEX_VERSION, indexVersion);
   }
 
+  public int getZkStatVersion() {
+    return _znRecord.getVersion();
+  }
+
+  public void setZkStatVersion(int zkStatVersion) {

Review comment:
       +1. This setter method won't necessarily get called anywhere since this version is already set in ZNode.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org