[GitHub] [johnzon] rmannibucau commented on pull request #82: enhance OSGi support

[GitBox <gi...@apache.org>]

rmannibucau commented on pull request #82:
URL: https://github.com/apache/johnzon/pull/82#issuecomment-1070411868


   Hi @stbischof ,
   
   when we discussed OSGi support we decided to:
   
   1. use maven bundle plugin and not bnd plugin
   2. not put any OSGi dependency/code in all modules but OSGi (all being done through maven plugin)
   
   About internal packages, I fear we need to export them since some integration use them - in particular websocket module (they are probably misnamed for OSGi users).
   
   About BufferStrategy SPI usage: it is unrelated to OSGi so likely belongs to a dedicated ticket but would also need an use case I think since it is not recommended to change it (even a few default ones are for very particular cases so not sure which case we don't already cover and I'd like to avoid a SPI if not needed). Also note that the SPI usage of JSON-P - including johnzon impl - is through the maps passed to factories, not another ServiceLoader after the provider loading so if there is a need it belongs to props IMHO.
   
   Hope it makes sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org