You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com> on 2013/02/14 05:55:01 UTC

Review Request: Support for full clones on ESX for Cloudstack (CS-670)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/
-----------------------------------------------------------

Review request for cloudstack and Kelven Yang.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs
-----

core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e1ca6cc
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253
server/conf/migration-components.xml 90fbafa
server/src/com/cloud/configuration/Config.java b22bf4b
server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff
server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION
server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION
setup/db/create-schema.sql 11ae267
setup/db/db/schema-40to410.sql 7f00441

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
Linked clones and full clones can reside together in the same cluster and work as expected.

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3440
> > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3440>
> >
> >     Assign a clone type of linked or full to userVmCloneType variable and change the value if global parameter is otherwise.

That's a good idea, will do that.


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3441
> > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3441>
> >
> >
> 
> Sateesh Chodapuneedi wrote:
>     Instead use getFullCloneFlag() defined in VmwareManager.

Actually I had to re-read the config for this reason - The problem is that if I import com.cloud.hypervisor.vmware.manager.VmwareManager;, I get an error in eclipse that says "The import com.cloud.hypervisor.vmware cannot be resolved" - looks like there are dependency issues. Any idea how I can get over it? During compilation, this is the error : "/root/vijay/mywork/cloudstack/asf/asf-ws/incubator-cloudstack/server/src/com/cloud/vm/UserVmManagerImpl.java:[280,42] package com.cloud.hypervisor.vmware.manager does not exist".


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3443
> > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3443>
> >
> >     Better to declare enum for cloneType

Yes that would be better - will do that.


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3452
> > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3452>
> >
> >     Is cleanup of the this row taken care when VM with id gets removed?

I noticed that vm_instance and user_vm entries for VMs aren't removed when the VM is destroyed. So I didn't remove the entries in the new user_vm_clone_setting table either. I think it's better to retain that entry when we have an option to restore a destroyed user VM.


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > setup/db/db/schema-40to410.sql, line 1327
> > <https://reviews.apache.org/r/9439/diff/1/?file=258730#file258730line1327>
> >
> >     Why is the table name different from user_vm_clone_setting in create-schema.sql?

Oh thanks for catching that! I hadn't tested upgrade path yet. Will make the required change to this file. The table name must be user_vm_clone_setting.


Will update the diffs with the above modifications at the earliest. Thanks a ton for the prompt review Sateesh!


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > setup/db/create-schema.sql, line 2687
> > <https://reviews.apache.org/r/9439/diff/1/?file=258729#file258729line2687>
> >
> >     Make this FOREIGN KEY with clause "ON DELETE SET CASCADE" to enable cascaded deletion of the row when the corresponding VM row is deleted in vm instance table.

As described in the point above, I think we shouldn't be doing this..


- Venkata Siva Vijayendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16564
-----------------------------------------------------------


On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e1ca6cc 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java b22bf4b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   setup/db/create-schema.sql 11ae267 
>   setup/db/db/schema-40to410.sql 7f00441 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.


> On Feb. 14, 2013, 6:58 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 3441
> > <https://reviews.apache.org/r/9439/diff/1/?file=258726#file258726line3441>
> >
> >

Instead use getFullCloneFlag() defined in VmwareManager.


- Sateesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16564
-----------------------------------------------------------


On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e1ca6cc 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java b22bf4b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   setup/db/create-schema.sql 11ae267 
>   setup/db/db/schema-40to410.sql 7f00441 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16564
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9439/#comment35146>

    Assign a clone type of linked or full to userVmCloneType variable and change the value if global parameter is otherwise.



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9439/#comment35143>

    



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9439/#comment35144>

    Better to declare enum for cloneType 



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9439/#comment35147>

    Is cleanup of the this row taken care when VM with id gets removed?



setup/db/create-schema.sql
<https://reviews.apache.org/r/9439/#comment35148>

    Make this FOREIGN KEY with clause "ON DELETE SET CASCADE" to enable cascaded deletion of the row when the corresponding VM row is deleted in vm instance table.



setup/db/db/schema-40to410.sql
<https://reviews.apache.org/r/9439/#comment35149>

    Why is the table name different from user_vm_clone_setting in create-schema.sql?


- Sateesh Chodapuneedi


On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e1ca6cc 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java b22bf4b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   setup/db/create-schema.sql 11ae267 
>   setup/db/db/schema-40to410.sql 7f00441 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.


> On Feb. 15, 2013, 4:47 a.m., Sateesh Chodapuneedi wrote:
> > server/src/com/cloud/vm/UserVmManagerImpl.java, line 289
> > <https://reviews.apache.org/r/9439/diff/2/?file=258883#file258883line289>
> >
> >     Better to rename it to start with Capital letter as this is name of data type.

Yes, will do that.


- Venkata Siva Vijayendra


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16625
-----------------------------------------------------------


On Feb. 15, 2013, 10:53 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 10:53 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16625
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9439/#comment35291>

    Better to rename it to start with Capital letter as this is name of data type.


- Sateesh Chodapuneedi


On Feb. 15, 2013, 12:33 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 12:33 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   setup/db/db/schema-40to410.sql 7f00441 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Kelven Yang <ke...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16981
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On Feb. 23, 2013, 2:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 2:23 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 6b6bf19 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f754c58 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java 8c77715 
>   server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
>   setup/db/db/schema-410to420.sql 4637b6d 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16994
-----------------------------------------------------------

Ship it!


Ship It!

- Sateesh Chodapuneedi


On Feb. 23, 2013, 2:23 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2013, 2:23 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 6b6bf19 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f754c58 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java 8c77715 
>   server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
>   setup/db/db/schema-410to420.sql 4637b6d 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 25, 2013, 10:48 p.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Uploading latest consolidated diff that applies on master.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs (updated)
-----

core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 6b6bf19
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f754c58
server/conf/migration-components.xml 90fbafa
server/src/com/cloud/configuration/Config.java 1cea9aa
server/src/com/cloud/vm/UserVmManagerImpl.java 6cb3f1a
server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION
server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION
server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql be8e7f5

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 23, 2013, 2:23 a.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Please find the final consolidated diff on top of master attached.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs (updated)
-----

core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 6b6bf19
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f754c58
server/conf/migration-components.xml 90fbafa
server/src/com/cloud/configuration/Config.java 8c77715
server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27
server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION
server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION
server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql 4637b6d

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 22, 2013, 9:42 p.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Uploading single diff containing all changes.

PLEASE NOTE: The db changes were shifted from schema-40to410.sql to schema-410to420.sql but that isn't working on the current master - the tables in schema-410to420.sql (user_vm_clone_setting of this feature, data_store_provider and image_data_store) are not getting created in the cloud db. Looking into it, will consult cloudstack-dev@i.a.o.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs (updated)
-----

core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java 445b2f0
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 6b6bf19
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java f754c58
server/conf/migration-components.xml 90fbafa
server/src/com/cloud/configuration/Config.java 8c77715
server/src/com/cloud/vm/UserVmManagerImpl.java cf9eb27
server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION
server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION
server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION
setup/db/db/schema-410to420.sql 4637b6d

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Chip Childers <ch...@sungard.com>.

This should only be applied to master, since it didn't make it into 4.1
by the feature freeze.  You guys might already know that, but Frank's
comment in the review was about the 4.1 branch.

-chip

On Fri, Feb 22, 2013 at 11:27:17AM -0800, Vijayendra Bhamidipati wrote:
> Hi Frank,
> 
> I'll submit a single diff shortly and ping you.
> 
> Regards,
> Vijay
> 
> -----Original Message-----
> From: Frank Zhang [mailto:noreply@reviews.apache.org] On Behalf Of Frank Zhang
> Sent: Friday, February 22, 2013 11:12 AM
> To: Kelven Yang
> Cc: cloudstack; Vijayendra Bhamidipati; Frank Zhang
> Subject: Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)
> 
> 
> 
> > On Feb. 22, 2013, 2:08 a.m., Kelven Yang wrote:
> > > Ship It!
> 
> cannot apply patch, it diversify much that current 4.1 branch. please rebase and summit again
> 
> 
> - Frank
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/#review16918
> -----------------------------------------------------------
> 
> 
> On Feb. 15, 2013, 8:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> > 
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/9439/
> > -----------------------------------------------------------
> > 
> > (Updated Feb. 15, 2013, 8:47 p.m.)
> > 
> > 
> > Review request for cloudstack and Kelven Yang.
> > 
> > 
> > Description
> > -------
> > 
> > Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> > 
> > 
> > This addresses bug CS-670.
> > 
> > 
> > Diffs
> > -----
> > 
> >   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
> >   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
> >   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
> >   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
> > 
> > Diff: https://reviews.apache.org/r/9439/diff/
> > 
> > 
> > Testing
> > -------
> > 
> > Manual Testing
> > ==============
> > 
> > Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> > Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> > Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> > Linked clones and full clones can reside together in the same cluster and work as expected.
> > 
> > 
> > Thanks,
> > 
> > Venkata Siva Vijayendra Bhamidipati
> > 
> >
>

RE: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Vijayendra Bhamidipati <vi...@citrix.com>.

Hi Frank,

I'll submit a single diff shortly and ping you.

Regards,
Vijay

-----Original Message-----
From: Frank Zhang [mailto:noreply@reviews.apache.org] On Behalf Of Frank Zhang
Sent: Friday, February 22, 2013 11:12 AM
To: Kelven Yang
Cc: cloudstack; Vijayendra Bhamidipati; Frank Zhang
Subject: Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)



> On Feb. 22, 2013, 2:08 a.m., Kelven Yang wrote:
> > Ship It!

cannot apply patch, it diversify much that current 4.1 branch. please rebase and summit again


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16918
-----------------------------------------------------------


On Feb. 15, 2013, 8:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 8:47 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Frank Zhang <fr...@citrix.com>.


> On Feb. 22, 2013, 2:08 a.m., Kelven Yang wrote:
> > Ship It!

cannot apply patch, it diversify much that current 4.1 branch. please rebase and summit again


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16918
-----------------------------------------------------------


On Feb. 15, 2013, 8:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 8:47 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Kelven Yang <ke...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16918
-----------------------------------------------------------

Ship it!


Ship It!

- Kelven Yang


On Feb. 15, 2013, 8:47 p.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 8:47 p.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION 
>   server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION 
>   server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 15, 2013, 8:47 p.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Making db related changes to remove DDL statement from create-schema.sql

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs
-----

server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoImplTest.java PRE-CREATION
server/test/com/cloud/vm/dao/UserVmCloneSettingDaoTestConfiguration.java PRE-CREATION
server/test/resources/CloneSettingDaoTestContext.xml PRE-CREATION

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 15, 2013, 8:45 p.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Attempting to re-upload patch 3. Hopefully it will be readable via reviewboard. If not, please refer to the attached file.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 15, 2013, 10:56 a.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

For some reason, review board isn't accepting the 3rd diff containing the unit tests and the enum changes. So, uploading the diff as a file. Please apply this diff on top of the first two diffs.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs
-----

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

(Updated Feb. 15, 2013, 10:53 a.m.)

Review request for cloudstack and Kelven Yang.

Changes
-------

Adding Unit tests for the UserVmCloneSettingDao and VO code.
Changing the enum datatype name.

Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.

This addresses bug CS-670.

Diffs (updated)
-----

Diff: https://reviews.apache.org/r/9439/diff/

Testing
-------

Manual Testing
==============

Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Venkata Siva Vijayendra Bhamidipati <vi...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/
-----------------------------------------------------------

(Updated Feb. 15, 2013, 12:33 a.m.)


Review request for cloudstack and Kelven Yang.


Changes
-------

Uploading diff of changes suggested by Sateesh.


Description
-------

Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.


This addresses bug CS-670.


Diffs (updated)
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
  setup/db/db/schema-40to410.sql 7f00441 

Diff: https://reviews.apache.org/r/9439/diff/


Testing
-------

Manual Testing
==============

Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
Linked clones and full clones can reside together in the same cluster and work as expected.


Thanks,

Venkata Siva Vijayendra Bhamidipati

Re: Review Request: Support for full clones on ESX for Cloudstack (CS-670)

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9439/#review16565
-----------------------------------------------------------


- Sateesh Chodapuneedi


On Feb. 14, 2013, 4:54 a.m., Venkata Siva Vijayendra Bhamidipati wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9439/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2013, 4:54 a.m.)
> 
> 
> Review request for cloudstack and Kelven Yang.
> 
> 
> Description
> -------
> 
> Please find the diffs for full clone guest VM support for ESX on Cloudstack. The diffs do not include unit tests yet. The tests will be uploaded at the earliest.
> 
> 
> This addresses bug CS-670.
> 
> 
> Diffs
> -----
> 
>   core/src/com/cloud/vm/UserVmCloneSettingVO.java PRE-CREATION 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManager.java e1ca6cc 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java 88e03f5 
>   plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java 5cac253 
>   server/conf/migration-components.xml 90fbafa 
>   server/src/com/cloud/configuration/Config.java b22bf4b 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 19887ff 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDao.java PRE-CREATION 
>   server/src/com/cloud/vm/dao/UserVmCloneSettingDaoImpl.java PRE-CREATION 
>   setup/db/create-schema.sql 11ae267 
>   setup/db/db/schema-40to410.sql 7f00441 
> 
> Diff: https://reviews.apache.org/r/9439/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> ==============
> 
> Creation of guest VMs when the global flag vmware.create.full.clone is set to its default value of false will create those guest VMs as linked clones (current default behavior without these changes).
> Creation of guest VMs when the global flag vmware.create.full.clone is set to true will create those guest VMs as full clones.
> Appropriate entries are created in the user_vm_clone_setting table of the cloud schema to reflect the clone type of the VMs.
> Linked clones and full clones can reside together in the same cluster and work as expected.
> 
> 
> Thanks,
> 
> Venkata Siva Vijayendra Bhamidipati
> 
>