You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chen Song <ch...@hotmail.com> on 2016/06/08 19:09:11 UTC
Re: Review Request 37026: SAMZA-727: Support for Kerberos
> On May 24, 2016, 3:31 a.m., Yi Pan (Data Infrastructure) wrote:
> > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala, line 111
> > <https://reviews.apache.org/r/37026/diff/4-6/?file=1345582#file1345582line111>
> >
> > Instead of removing this completely, I think it would be better to keep this code when the application exiting status is either "SUCCEEDED" or "KILLED" (defined in FinalApplicationStatus class).
Good point. I will refactor.
- Chen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37026/#review134501
-----------------------------------------------------------
On May 8, 2016, 12:50 a.m., Chen Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37026/
> -----------------------------------------------------------
>
> (Updated May 8, 2016, 12:50 a.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> Basic support for kerberization based on keytab authentication.
>
>
> Diffs
> -----
>
> build.gradle 16facbb
> samza-core/src/main/java/org/apache/samza/container/SecurityManager.java PRE-CREATION
> samza-core/src/main/java/org/apache/samza/container/SecurityManagerFactory.java PRE-CREATION
> samza-core/src/main/scala/org/apache/samza/config/JobConfig.scala 4d5ca4d
> samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala 5462208
> samza-yarn/src/main/java/org/apache/samza/config/YarnConfig.java c556d83
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/ClientHelper.scala 74a0676
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala 80deb3b
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterSecurityManager.scala PRE-CREATION
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterService.scala 3adf86f
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaContainerSecurityManager.scala PRE-CREATION
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaYarnSecurityManagerFactory.scala PRE-CREATION
> samza-yarn/src/main/scala/org/apache/samza/job/yarn/YarnJob.scala 62ddb26
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestClientHelper.scala PRE-CREATION
> samza-yarn/src/test/scala/org/apache/samza/job/yarn/TestSamzaAppMasterService.scala 7f5d9f4
>
> Diff: https://reviews.apache.org/r/37026/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chen Song
>
>