You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2023/01/16 07:37:18 UTC

[GitHub] [dolphinscheduler] Tianqi-Dotes commented on a diff in pull request #13379: [feature][api-datasource]add redshift auth mode to get connection by access key

Tianqi-Dotes commented on code in PR #13379:
URL: https://github.com/apache/dolphinscheduler/pull/13379#discussion_r1070913942


##########
dolphinscheduler-ui/src/views/datasource/list/detail.tsx:
##########
@@ -245,7 +246,11 @@ const DetailModal = defineComponent({
                   v-show={showPort}
                   label={t('datasource.port')}
                   path='port'
-                  show-require-mark
+                  show-require-mark={
+                    showMode && detailForm.mode === 'IAM-accessKey'
+                      ? false
+                      : true

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org