You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/01/04 13:13:05 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4231: kvm/ceph: Only if a port number has been specified define in the XML

DaanHoogland commented on a change in pull request #4231:
URL: https://github.com/apache/cloudstack/pull/4231#discussion_r551308642



##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java
##########
@@ -28,7 +28,7 @@ public static String RBDStringBuilder(String monHost, int monPort, String authUs
 
         rbdOpts = "rbd:" + image;
         rbdOpts += ":mon_host=" + monHost;
-        if (monPort != 6789) {
+        if (monPort > 0) {
             rbdOpts += "\\\\:" + monPort;

Review comment:
       this double escape seems to byte us now ;P during release of 4.15




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org