You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Yuxuan Wang (Jira)" <ji...@apache.org> on 2025/03/21 16:28:00 UTC
[jira] [Commented] (THRIFT-5858) Introduce a new type SIZE_LIMIT in TTransportException
[ https://issues.apache.org/jira/browse/THRIFT-5858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17937462#comment-17937462 ]
Yuxuan Wang commented on THRIFT-5858:
-------------------------------------
One note: SIZE_LIMIT is already currently used by TProtocolException. While this is not a problem with most languages, it is a problem with certain language libs, like go, that the enums are not namespaced so we cannot use the same name for different exception types. So _if_ we want to proceed with this proposal we need to find a different name.
> Introduce a new type SIZE_LIMIT in TTransportException
> ------------------------------------------------------
>
> Key: THRIFT-5858
> URL: https://issues.apache.org/jira/browse/THRIFT-5858
> Project: Thrift
> Issue Type: Bug
> Reporter: Zhihua Deng
> Priority: Major
>
> If the transport reads more bytes than the configured max message size, it will throw theĀ
> the TTransportException with the type TTransportException.END_OF_FILE. This could be a problem when the TThreadPoolServer ignore the exception and kill the connection silently, the client will receive the 'Socket closed by peer' exception, but there is no message in server to tell what's happening.
> In my idea, rather than throwing the exception with END_OF_FILE, we should flag this exception with a new type SIZE_LIMIT.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)