[GitHub] [skywalking] wankai123 commented on a diff in pull request #9199: ElasticSearch: scroll id should be updated when scrolling as it may change

[GitBox <gi...@apache.org>]

wankai123 commented on code in PR #9199:
URL: https://github.com/apache/skywalking/pull/9199#discussion_r894216455


##########
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/cache/NetworkAddressAliasEsDAO.java:
##########
@@ -62,8 +64,10 @@ public List<NetworkAddressAlias> loadLastUpdate(long timeBucketInMinute) {
 
             SearchResponse results =
                 getClient().search(NetworkAddressAlias.INDEX_NAME, search, params);
-            final String scrollId = results.getScrollId();
+            final Set<String> scrollIds = new HashSet<>();
             try {
+                final String scrollId = results.getScrollId();
+                scrollIds.add(scrollId);

Review Comment:
   should inside 'while' ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org