You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2018/07/27 10:41:26 UTC

[GitHub] spark pull request #21882: [SPARK-24934][SQL] Explicitly whitelist supported...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21882#discussion_r205734835
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/columnar/InMemoryTableScanExec.scala ---
    @@ -183,6 +183,18 @@ case class InMemoryTableScanExec(
       private val stats = relation.partitionStatistics
       private def statsFor(a: Attribute) = stats.forAttribute(a)
     
    +  // Currently, only use statistics from atomic types except binary type only.
    +  private object ExtractableLiteral {
    +    def unapply(expr: Expression): Option[Literal] = expr match {
    +      case lit: Literal => lit.dataType match {
    +        case BinaryType => None
    --- End diff --
    
    can we also add test for binary type?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org