You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by sc...@apache.org on 2019/11/21 17:14:37 UTC
[tomcat] branch 8.5.x updated: Add RFC references.
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new fdf0ba0 Add RFC references.
fdf0ba0 is described below
commit fdf0ba0aaebaffd588077defea0f56d6ba81396e
Author: Christopher Schultz <ch...@christopherschultz.net>
AuthorDate: Thu Nov 21 11:17:54 2019 -0500
Add RFC references.
---
java/org/apache/catalina/servlets/WebdavServlet.java | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java b/java/org/apache/catalina/servlets/WebdavServlet.java
index ef5573d..f870443 100644
--- a/java/org/apache/catalina/servlets/WebdavServlet.java
+++ b/java/org/apache/catalina/servlets/WebdavServlet.java
@@ -61,7 +61,10 @@ import org.xml.sax.InputSource;
import org.xml.sax.SAXException;
/**
- * Servlet which adds support for WebDAV level 2. All the basic HTTP requests
+ * Servlet which adds support for
+ * <a href="https://tools.ietf.org/html/rfc4918">WebDAV</a>
+ * <a href="https://tools.ietf.org/html/rfc4918#section-18">level 2</a>.
+ * All the basic HTTP requests
* are handled by the DefaultServlet. The WebDAVServlet must not be used as the
* default servlet (ie mapped to '/') as it will not work in this configuration.
* <p>
@@ -120,6 +123,8 @@ import org.xml.sax.SAXException;
* http://host:port/context/webdavedit/content
*
* @author Remy Maucherat
+ *
+ * @see https://tools.ietf.org/html/rfc4918
*/
public class WebdavServlet extends DefaultServlet {
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 8.5.x updated: Add RFC references.
Posted by Konstantin Kolinko <kn...@gmail.com>.
пт, 22 нояб. 2019 г. в 22:49, Christopher Schultz
<ch...@christopherschultz.net>:
>
> Konstantin,
>
> On 11/21/19 12:36, Konstantin Kolinko wrote:
> > чт, 21 нояб. 2019 г. в 20:14, <sc...@apache.org>:
> >>
> >> [...]
> >>
> >> commit fdf0ba0aaebaffd588077defea0f56d6ba81396e Author:
> >> Christopher Schultz <ch...@christopherschultz.net> AuthorDate:
> >> Thu Nov 21 11:17:54 2019 -0500
> >>
> >> Add RFC references. ---
> >> java/org/apache/catalina/servlets/WebdavServlet.java | 7 ++++++-
> >> 1 file changed, 6 insertions(+), 1 deletion(-)
> >>
> >> [...]
> >>
> >> + * @see https://tools.ietf.org/html/rfc4918 */
> >
> > This change triggered a compilation failure at Buildbot, see
> > https://ci.apache.org/builders/tomcat-85-trunk/builds/2053
> >
> > IIRC, if a plain URL is used in a '@see' tag it should be in double
> > quotes, @see "https://tools.ietf.org/html/rfc4918"
>
> Thank you for the review. I didn't check javadoc warnings before
> committing.
>
> Here is the documentation for @see:
>
> https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.ht
> ml#see
>
> Should I instead use:
>
> @see <a href="...">...</a>
>
> ?
Yes.
Thank you.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 8.5.x updated: Add RFC references.
Posted by Christopher Schultz <ch...@christopherschultz.net>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Konstantin,
On 11/21/19 12:36, Konstantin Kolinko wrote:
> чт, 21 нояб. 2019 г. в 20:14, <sc...@apache.org>:
>>
>> This is an automated email from the ASF dual-hosted git
>> repository.
>>
>> schultz pushed a commit to branch 8.5.x in repository
>> https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/8.5.x by this
>> push: new fdf0ba0 Add RFC references. fdf0ba0 is described
>> below
>>
>> commit fdf0ba0aaebaffd588077defea0f56d6ba81396e Author:
>> Christopher Schultz <ch...@christopherschultz.net> AuthorDate:
>> Thu Nov 21 11:17:54 2019 -0500
>>
>> Add RFC references. ---
>> java/org/apache/catalina/servlets/WebdavServlet.java | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java
>> b/java/org/apache/catalina/servlets/WebdavServlet.java index
>> ef5573d..f870443 100644 ---
>> a/java/org/apache/catalina/servlets/WebdavServlet.java +++
>> b/java/org/apache/catalina/servlets/WebdavServlet.java @@ -61,7
>> +61,10 @@ import org.xml.sax.InputSource; import
>> org.xml.sax.SAXException;
>>
>> /** - * Servlet which adds support for WebDAV level 2. All the
>> basic HTTP requests + * Servlet which adds support for + * <a
>> href="https://tools.ietf.org/html/rfc4918">WebDAV</a> + * <a
>> href="https://tools.ietf.org/html/rfc4918#section-18">level
>> 2</a>. + * All the basic HTTP requests * are handled by the
>> DefaultServlet. The WebDAVServlet must not be used as the *
>> default servlet (ie mapped to '/') as it will not work in this
>> configuration. * <p> @@ -120,6 +123,8 @@ import
>> org.xml.sax.SAXException; *
>> http://host:port/context/webdavedit/content * * @author Remy
>> Maucherat + * + * @see https://tools.ietf.org/html/rfc4918 */
>
> This change triggered a compilation failure at Buildbot, see
> https://ci.apache.org/builders/tomcat-85-trunk/builds/2053
>
> IIRC, if a plain URL is used in a '@see' tag it should be in double
> quotes, @see "https://tools.ietf.org/html/rfc4918"
Thank you for the review. I didn't check javadoc warnings before
committing.
Here is the documentation for @see:
https://docs.oracle.com/javase/7/docs/technotes/tools/windows/javadoc.ht
ml#see
Should I instead use:
@see <a href="...">...</a>
?
- -chris
-----BEGIN PGP SIGNATURE-----
Comment: Using GnuPG with Thunderbird - https://www.enigmail.net/
iQIzBAEBCAAdFiEEMmKgYcQvxMe7tcJcHPApP6U8pFgFAl3YO9IACgkQHPApP6U8
pFg0QQ/8C3fJ9P6JVQdr3KyuZe23wnmxhJlvX8BSwL1GV7swpXufxF+zatsAjvzT
WTXwkmiXjSGtan+a9mG6qvUv2y3EQjvZtxrTzltd1R3AN8A/noY7Q6LcgZjHswS5
6mOMNq52VuGkH28UXkpTp3/zXi1893kHwSqxwtpgUGcgpS7Be/+CCvbo4NPzDHkl
YW5XuDrGQITgXjtELYUoYhl4qmakjQCesy3pG9C9IcewQ0eHm9j2ToiSSo30BOSF
yisUcub1jDSWyfiJjb4zl8gLklCmYtPdIroUdoTy1rBigv6yZ8UuSlA5uVvmvEYc
sIE3S/tIaxZgqsrvB2+oGvvO/JlkEboomeMnJaZFRPAstsm6uU2vpa9BOr4MLG81
Wi3m2LoOxxpGRhpE0i/U+ue4RcGIaaAyjFMDPqVuvXBwhPF80ozKdebMQ3gGW2mu
ItMZnukD5k3IrR94AMMJq5v1KT8Hr3jf5qX4FY3ubGrAuZZwmuPZY5gT3Iq9LECi
TmHWeHSUu368wSBYvC/aaAc4rEX3rFx2uR8irAtNPf9wIEMLg8GMC0pusUCfPsLt
NQLtFqE4ZWt4I+wI8q603Z8H+VX1fVzKU9MBZ6SnnUmx0lWSAqRRMiMNDCmq7qlD
24eSUh7irr1omJYtKB/WuWQsvp5bnNFavxJAO2e55ccc6JJ07l4=
=9b3w
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch 8.5.x updated: Add RFC references.
Posted by Konstantin Kolinko <kn...@gmail.com>.
чт, 21 нояб. 2019 г. в 20:14, <sc...@apache.org>:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> schultz pushed a commit to branch 8.5.x
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/8.5.x by this push:
> new fdf0ba0 Add RFC references.
> fdf0ba0 is described below
>
> commit fdf0ba0aaebaffd588077defea0f56d6ba81396e
> Author: Christopher Schultz <ch...@christopherschultz.net>
> AuthorDate: Thu Nov 21 11:17:54 2019 -0500
>
> Add RFC references.
> ---
> java/org/apache/catalina/servlets/WebdavServlet.java | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/java/org/apache/catalina/servlets/WebdavServlet.java b/java/org/apache/catalina/servlets/WebdavServlet.java
> index ef5573d..f870443 100644
> --- a/java/org/apache/catalina/servlets/WebdavServlet.java
> +++ b/java/org/apache/catalina/servlets/WebdavServlet.java
> @@ -61,7 +61,10 @@ import org.xml.sax.InputSource;
> import org.xml.sax.SAXException;
>
> /**
> - * Servlet which adds support for WebDAV level 2. All the basic HTTP requests
> + * Servlet which adds support for
> + * <a href="https://tools.ietf.org/html/rfc4918">WebDAV</a>
> + * <a href="https://tools.ietf.org/html/rfc4918#section-18">level 2</a>.
> + * All the basic HTTP requests
> * are handled by the DefaultServlet. The WebDAVServlet must not be used as the
> * default servlet (ie mapped to '/') as it will not work in this configuration.
> * <p>
> @@ -120,6 +123,8 @@ import org.xml.sax.SAXException;
> * http://host:port/context/webdavedit/content
> *
> * @author Remy Maucherat
> + *
> + * @see https://tools.ietf.org/html/rfc4918
> */
This change triggered a compilation failure at Buildbot, see
https://ci.apache.org/builders/tomcat-85-trunk/builds/2053
IIRC, if a plain URL is used in a '@see' tag it should be in double quotes,
@see "https://tools.ietf.org/html/rfc4918"
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org