You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by Tilman Hausherr <TH...@t-online.de> on 2018/07/22 10:58:21 UTC

preflight build fails

https://issues.apache.org/jira/browse/INFRA-16800



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Re: preflight build fails

Posted by Andreas Lehmkuehler <an...@lehmi.de>.
Am 23.07.2018 um 19:00 schrieb Tilman Hausherr:
> Am 22.07.2018 um 12:58 schrieb Tilman Hausherr:
>> https://issues.apache.org/jira/browse/INFRA-16800 
> 
> The build works now, but there are 3 problems left:
@Tilman Thanks for fixing this

> 1) Karl Heinz Marbaise suggested that we put the test files into a separate 
> project, I don't see this as a good idea, but maybe I didn't understand
He has some security concerns, as we don't control all of the servers which 
could be a security risk

> 2) He also suggested that there is no need to produce a source package for the 
> snapshots. I agree, but don't know how to do it, while keeping the sources for 
> the releases => Andreas
I've disabled the source jars for all builds but the sonar build (it doesn't 
create those jars at all) by adding  -Dmaven.source.skip=true

> 3) not related to the INFRA issue, but also interesting: we get warnings for the 
> three -app builds:
> 
> --- maven-bundle-plugin:3.5.0:bundle (default-bundle) @ debugger-app ---
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.debugger.ui,  has 1,  private references 
> [org.apache.commons.logging],
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.io,  has 1,  private references [org.apache.commons.logging],
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.pdmodel,  has 1,  private references [org.apache.fontbox.ttf],
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.pdmodel.common,  has 1,  private references 
> [org.apache.fontbox.util],
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.pdmodel.font,  has 8,  private references [org.apache.fontbox, 
> org.apache.fontbox.afm, org.apache.fontbox.cff, org.apache.fontbox.cmap, 
> org.apache.fontbox.ttf, org.apache.fontbox.ttf.model, org.apache.fontbox.type1, 
> org.apache.fontbox.util],
> Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
> org.apache.pdfbox.pdmodel.font.encoding,  has 2,  private references 
> [org.apache.fontbox.afm, org.apache.fontbox.encoding],
> 
> I checked the jar file, fontbox and commons-logging are indeed exported. 
> Assuming that this is what we wanted, then we can get rid of the warning by 
> inserting one line in the bundle-plugin segments. For debugger-app and 
> pdfbox-app one can add
> <_exportcontents>org.apache.fontbox.*,org.apache.commons.logging.*</_exportcontents> 
> 
> and for preflight-app
> <_exportcontents>org.apache.fontbox.*,org.apache.xmpbox.*,org.apache.commons.logging.*</_exportcontents> 
> 
> 
> I'd like to have a second opinion on that one because I'm not using the bundle 
> plugin in my daily life.
> 
> See also 
> https://stackoverflow.com/questions/21218296/maven-bundle-plugin-export-has-private-references 
> 
> 
> Tilman
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


Re: preflight build fails

Posted by Tilman Hausherr <TH...@t-online.de>.
Am 22.07.2018 um 12:58 schrieb Tilman Hausherr:
> https://issues.apache.org/jira/browse/INFRA-16800 

The build works now, but there are 3 problems left:

1) Karl Heinz Marbaise suggested that we put the test files into a 
separate project, I don't see this as a good idea, but maybe I didn't 
understand
2) He also suggested that there is no need to produce a source package 
for the snapshots. I agree, but don't know how to do it, while keeping 
the sources for the releases => Andreas
3) not related to the INFRA issue, but also interesting: we get warnings 
for the three -app builds:

--- maven-bundle-plugin:3.5.0:bundle (default-bundle) @ debugger-app ---
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.debugger.ui,  has 1,  private references 
[org.apache.commons.logging],
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.io,  has 1,  private references 
[org.apache.commons.logging],
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.pdmodel,  has 1,  private references 
[org.apache.fontbox.ttf],
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.pdmodel.common,  has 1,  private references 
[org.apache.fontbox.util],
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.pdmodel.font,  has 8,  private references 
[org.apache.fontbox, org.apache.fontbox.afm, org.apache.fontbox.cff, 
org.apache.fontbox.cmap, org.apache.fontbox.ttf, 
org.apache.fontbox.ttf.model, org.apache.fontbox.type1, 
org.apache.fontbox.util],
Bundle org.apache.pdfbox:debugger-app:bundle:3.0.0-TILMAN : Export 
org.apache.pdfbox.pdmodel.font.encoding,  has 2,  private references 
[org.apache.fontbox.afm, org.apache.fontbox.encoding],

I checked the jar file, fontbox and commons-logging are indeed exported. 
Assuming that this is what we wanted, then we can get rid of the warning 
by inserting one line in the bundle-plugin segments. For debugger-app 
and pdfbox-app one can add
<_exportcontents>org.apache.fontbox.*,org.apache.commons.logging.*</_exportcontents>
and for preflight-app
<_exportcontents>org.apache.fontbox.*,org.apache.xmpbox.*,org.apache.commons.logging.*</_exportcontents>

I'd like to have a second opinion on that one because I'm not using the 
bundle plugin in my daily life.

See also 
https://stackoverflow.com/questions/21218296/maven-bundle-plugin-export-has-private-references

Tilman