You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/15 21:20:35 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3121: Add Decimal128, Decimal256, Float16 to DataType::is_numeric

tustvold commented on code in PR #3121:
URL: https://github.com/apache/arrow-rs/pull/3121#discussion_r1023268748


##########
arrow-schema/src/datatype.rs:
##########
@@ -263,30 +263,13 @@ impl fmt::Display for DataType {
 
 impl DataType {
     /// Returns true if the type is primitive: (numeric, temporal).
+    #[inline]

Review Comment:
   Also took the opportunity to add `#[inline]` so that these inline correctly across crate boundaries - which will help with eliding redundant checks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org