You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/09/04 20:41:00 UTC

[jira] [Commented] (AIRFLOW-3003) Pull the krb5 image instead of building it

    [ https://issues.apache.org/jira/browse/AIRFLOW-3003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16603581#comment-16603581 ] 

ASF GitHub Bot commented on AIRFLOW-3003:
-----------------------------------------

Fokko opened a new pull request #3844: [AIRFLOW-3003] Pull the krb5 image instead of building
URL: https://github.com/apache/incubator-airflow/pull/3844
 
 
   Pull the image instead of building it, this will speed up the CI process since we don't have to build it every time.
   
   I did a test, on the current master (17.430 seconds in total): https://travis-ci.org/Fokko/incubator-airflow/builds/424438601 The PR takes 17.004 seconds in total: https://travis-ci.org/Fokko/incubator-airflow/builds/424479941
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-3003\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3003
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-3003\], code changes always need a Jira issue.
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [x] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Pull the krb5 image instead of building it
> ------------------------------------------
>
>                 Key: AIRFLOW-3003
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3003
>             Project: Apache Airflow
>          Issue Type: Improvement
>            Reporter: Fokko Driesprong
>            Assignee: Fokko Driesprong
>            Priority: Major
>
> For the CI we use a krb5 image to test kerberos functionality. This is not something that we want to since it is faster to pull the finished image.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)