[GitHub] [superset] kasiazjc commented on a diff in pull request #23603: feat: implement drill by table [WIP]

["kasiazjc (via GitHub)" <gi...@apache.org>]

kasiazjc commented on code in PR #23603:
URL: https://github.com/apache/superset/pull/23603#discussion_r1159606910


##########
superset-frontend/src/components/Chart/DrillBy/DrillByModal.tsx:
##########
@@ -62,18 +72,20 @@ const ModalFooter = ({ formData, closeModal }: ModalFooterProps) => {
   }, [dashboardPageId, datasource_id, datasource_type, formData]);
   return (
     <>
-      <Button buttonStyle="secondary" buttonSize="small" onClick={noOp}>
-        <Link
-          css={css`
-            &:hover {
-              text-decoration: none;
-            }
-          `}
-          to={url}
-        >
-          {t('Edit chart')}
-        </Link>
-      </Button>
+      {showEditChart && (

Review Comment:
   definitely agree with @kgabryje. Button should stay and should open the chart from the "chart" tab, as "table" tab is more like an underlying data, not viz



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org