You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/05/19 02:31:50 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
wangyang0918 opened a new pull request #12236:
URL: https://github.com/apache/flink/pull/12236
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Currently, `kubernetes-session.sh` uses the log4j-console.properties and `yarn-session.sh` uses `log4j-yarn-session.properties`. They should have the same logging configuration. This PR will rename `log4j-yarn-session.properties` to `log4j-session.properties`, `logback-yarn.xml` to `logback-session.xml`. This also will make the logback configuration aligned with log4j configuration.
## Brief change log
* 21d91c1c0e4c75beebc9b032ca3106977f65b073 Rename yarn log4j/logback configuration files so that they could be reused
* c3caf6974bdf8298376d150b00fd7e7125089986 Make `kubernetes-session.sh` use session log4j/logback configuration files
## Verifying this change
* Manually test on a Yarn/K8s cluster, the client console logging should be same with before
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630541737
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 69ffc38685d86f8414d93d33100efd7e90d3fb70 (Fri Oct 16 10:50:30 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630707403
@tillrohrmann Thanks for the `fixup`.
BTW, i do not suggest to backport this PR to release-1.10. Since we rename two files(e.g. `log4j-yarn-session.properties` -> `log4j-session.properties`, `logback-yarn.xml` -> `logback-session.xml`). Then it will be a surprise to our users with a `bugfix` upgrading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann closed pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #12236:
URL: https://github.com/apache/flink/pull/12236
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630547436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790",
"triggerID" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"triggerType" : "PUSH"
}, {
"hash" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1823",
"triggerID" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 69ffc38685d86f8414d93d33100efd7e90d3fb70 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on a change in pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on a change in pull request #12236:
URL: https://github.com/apache/flink/pull/12236#discussion_r427105554
##########
File path: docs/monitoring/logging.md
##########
@@ -35,7 +35,7 @@ Log4j2 is controlled using property files. In Flink's case, the file is usually
Flink ships with the following default properties files:
- `log4j-cli.properties`: Used by the Flink command line client (e.g. `flink run`) (not code executed on the cluster)
-- `log4j-yarn-session.properties`: Used by the Flink command line client when starting a YARN session (`yarn-session.sh`)
+- `log4j-session.properties`: Used by the Flink command line client when starting a YARN session (`yarn-session.sh`)
Review comment:
```suggestion
- `log4j-session.properties`: Used by the Flink command line client when starting a YARN or Kubernetes session (`yarn-session.sh`, `kubernetes-session.sh`)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630547436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790",
"triggerID" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"triggerType" : "PUSH"
}, {
"hash" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1823",
"triggerID" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3caf6974bdf8298376d150b00fd7e7125089986 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790)
* 69ffc38685d86f8414d93d33100efd7e90d3fb70 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1823)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630797584
Yes agreed @wangyang0918. It should only go into `1.11` and `1.12`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630547436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790",
"triggerID" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3caf6974bdf8298376d150b00fd7e7125089986 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wangyang0918 commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630590441
cc @tillrohrmann Could you please help to review this change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630541737
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c3caf6974bdf8298376d150b00fd7e7125089986 (Tue May 19 02:33:49 UTC 2020)
✅no warnings
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630547436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790",
"triggerID" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"triggerType" : "PUSH"
}, {
"hash" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "69ffc38685d86f8414d93d33100efd7e90d3fb70",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3caf6974bdf8298376d150b00fd7e7125089986 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=1790)
* 69ffc38685d86f8414d93d33100efd7e90d3fb70 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12236: [FLINK-17527][flink-dist] Make kubernetes-session.sh use session log4j/logback configuration files
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12236:
URL: https://github.com/apache/flink/pull/12236#issuecomment-630547436
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c3caf6974bdf8298376d150b00fd7e7125089986",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c3caf6974bdf8298376d150b00fd7e7125089986 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org