[GitHub] jmark99 opened a new pull request #302: ACCUMULO-2968: Axe TabletServer.majorCompactorDisabled

[gi...@git.apache.org]

jmark99 opened a new pull request #302: ACCUMULO-2968: Axe TabletServer.majorCompactorDisabled
URL: https://github.com/apache/accumulo/pull/302
 
 
   ACCUMULO-2968: Axe TabletServer.majorCompactorDisabled
   
   Removed references to majorCompatorDisabled variable defined in
   accumulo/tserver/TabletServer.java.  This private variable was
   defined as 'false' and never modified in source and additionally
   no means were provided to alter the value in the code.
   
   Several locations within TabletServer.java where updated. This
   included a couple of 'if' statement that would never be executed as well
   as some return statement where a constant value of true was
   unnecessarily included.
   
   There was one reference each within CompationRunner.java and Tablet.java
   which were removed also.
   
   The change of most note is probably the while loop within the run method
   of TableServer. Previously the while check read:
      while(!majorCompatorDisabled)....
   
   whereas now it reads:
      while(true)...
   
   which was what it would always equate too. This could be seen to be a
   loss of information perhaps. A comment was added to describe what
   existed prior to the update.
   
   After update all unit tests continued to pass as well as the 'sunny-day' integration tests.
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services