You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/03/14 17:53:39 UTC
[GitHub] [lucene] mocobeta opened a new pull request #746: Sanity check on start javaw
mocobeta opened a new pull request #746:
URL: https://github.com/apache/lucene/pull/746
This tests if Luke process successfully starts on "java" on Mac/Linux or "start javaw" on Windows.
TestScripts now checks if the expected message is contained in a log file instead of the forked process's stdout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta closed pull request #746: Sanity check on start javaw
Posted by GitBox <gi...@apache.org>.
mocobeta closed pull request #746:
URL: https://github.com/apache/lucene/pull/746
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #746: Sanity check on start javaw
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826266136
##########
File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java
##########
@@ -125,13 +134,29 @@ protected void execute(
throw new AssertionError("Forked process did not terminate in the expected time");
}
+ // Wait until the log file is created by Luke.
Review comment:
```suggestion
// Wait until the log file is created by the descendant process.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #746: Sanity check on start javaw
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826259906
##########
File path: lucene/distribution.tests/src/test/org/apache/lucene/distribution/TestScripts.java
##########
@@ -112,6 +120,7 @@ protected void execute(
Launcher launcher,
int expectedExitCode,
long timeoutInSeconds,
+ Path logFile,
Review comment:
I added this parameter for proof of concepts, but this can be (should be) `Optional<Path>`. If None is passed, `processOutputConsumer` would take stdout of the forked process as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene] mocobeta commented on a change in pull request #746: Sanity check on start javaw
Posted by GitBox <gi...@apache.org>.
mocobeta commented on a change in pull request #746:
URL: https://github.com/apache/lucene/pull/746#discussion_r826294904
##########
File path: lucene/distribution/src/binary-release/bin/luke.cmd
##########
@@ -18,21 +18,17 @@
SETLOCAL
SET MODULES=%~dp0..
-IF DEFINED LAUNCH_CMD GOTO testing
REM Windows 'start' command takes the first quoted argument to be the title of the started window. Since we
REM quote the LAUNCH_CMD (because it can contain spaces), it misinterprets it as the title and fails to run.
REM force the window title here.
SET LAUNCH_START=start "Lucene Luke"
+
+IF DEFINED LAUNCH_CMD GOTO testing
SET LAUNCH_CMD=javaw
SET LAUNCH_OPTS=
goto launch
:testing
-REM For distribution testing we don't use start and pass an explicit java command path,
-REM This is required because otherwise we can't block on luke invocation and can't intercept
-REM the return status. We also force UTF-8 encoding so that we don't have to interpret the output in
-REM an unknown local platform encoding.
Review comment:
This comment was wrongly removed; should be reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org