You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dustinpeerce (via GitHub)" <gi...@apache.org> on 2023/08/29 23:04:06 UTC
[GitHub] [solr] dustinpeerce opened a new pull request, #1872: Fix configuration parameter stateCompressor in solr-xml reference doc
dustinpeerce opened a new pull request, #1872:
URL: https://github.com/apache/solr/pull/1872
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The Solr Reference Guide for Configuring solr.xml contains an invalid parameter in the example file.
# Solution
I replaced the invalid parameter `compressor` with the correct parameter `stateCompressor`
# Tests
No tests were performed.
# Checklist
Please review the following and check all that apply:
- [✓] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [✓] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [✓] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [✓] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1872: Fix configuration parameter stateCompressor in solr-xml reference doc
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1699058232
Thanks @dustinpeerce ! Doc fixes are so important!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev commented on pull request #1872: Fix configuration parameter stateCompressor in solr-xml reference doc
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1699057850
Thanks you, Dustin.
Would you mind to create cherry-picking PR to branch_9x ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] mkhludnev merged pull request #1872: Fix configuration parameter stateCompressor in solr-xml reference doc
Posted by "mkhludnev (via GitHub)" <gi...@apache.org>.
mkhludnev merged PR #1872:
URL: https://github.com/apache/solr/pull/1872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dustinpeerce commented on pull request #1872: Fix configuration parameter stateCompressor in solr-xml reference doc
Posted by "dustinpeerce (via GitHub)" <gi...@apache.org>.
dustinpeerce commented on PR #1872:
URL: https://github.com/apache/solr/pull/1872#issuecomment-1700270234
@mkhludnev Created cherry-pick PR: [1874](https://github.com/apache/solr/pull/1874)
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org