You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by michaelbraun <gi...@git.apache.org> on 2018/06/03 20:48:13 UTC

[GitHub] lucene-solr pull request #392: LUCENE-8345 - add wrapper class constructors ...

GitHub user michaelbraun opened a pull request:

    https://github.com/apache/lucene-solr/pull/392

    LUCENE-8345 - add wrapper class constructors to forbiddenapis

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/michaelbraun/lucene-solr remove-constructor-wrapper-classes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/lucene-solr/pull/392.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #392
    
----
commit fb6574100e493ed9162265133f2cbe967746c166
Author: Michael Braun <n3...@...>
Date:   2018-06-03T19:40:50Z

    LUCENE-8345 - add wrapper class constructors to forbiddenapis

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[GitHub] lucene-solr pull request #392: LUCENE-8345 - add wrapper class constructors ...

Posted by uschindler <gi...@git.apache.org>.
Github user uschindler commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/392#discussion_r193109013
  
    --- Diff: lucene/tools/forbiddenApis/base.txt ---
    @@ -40,3 +40,21 @@ java.util.Collections#shuffle(java.util.List) @ Use shuffle(List, Random) instea
     
     java.util.Locale#forLanguageTag(java.lang.String) @ use new Locale.Builder().setLanguageTag(...).build() which has error handling
     java.util.Locale#toString() @ use Locale#toLanguageTag() for a standardized BCP47 locale name
    +
    +@defaultMessage Constructors for wrapper classes of Java primitives should be avoided in favor of the public static methods available or autoboxingT
    --- End diff --
    
    there is a typo at the end!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org

[GitHub] lucene-solr pull request #392: LUCENE-8345 - add wrapper class constructors ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/lucene-solr/pull/392


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org