[GitHub] [phoenix] gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #607: PHOENIX-5103: Can't create/drop table using 4.14 client against 4.15 server (Addendum)
URL: https://github.com/apache/phoenix/pull/607#discussion_r343243503
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java
 ##########
 @@ -2341,10 +2348,10 @@ private MetaDataMutationResult doDropTable(byte[] key, byte[] tenantId, byte[] s
 
             if (tableType == PTableType.TABLE || tableType == PTableType.VIEW || tableType == PTableType.SYSTEM) {
                 // check to see if the table has any child views
-                try (Table hTable =
-                             env.getTable(SchemaUtil.getPhysicalTableName(
-                                     PhoenixDatabaseMetaData.SYSTEM_CHILD_LINK_NAME_BYTES,
-                                     env.getConfiguration()))) {
+                try (Table hTable = env.getTable(SchemaUtil.getPhysicalTableName(
+                        clientVersion >= MIN_SPLITTABLE_SYSTEM_CATALOG ?
 
 Review comment:
   ditto extract method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services