You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tooling.apache.org by "sbp (via GitHub)" <gi...@apache.org> on 2026/09/30 18:48:23 UTC

[I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

sbp opened a new issue, #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650

   The key strength validation function contains a date condition that makes it a no-op for all keys created before 2026-04-01. Since no key can have been created after this future date, the validation currently rejects no keys. An authenticated committer can upload keys with weak algorithms (DSA, ElGamal, Diffie-Hellman) or undersized RSA keys (e.g., 1024-bit) without any rejection.
   
   ```python
   def _validate_key_strength(key: openpgp.composed.SignedPublicKey) -> None:
       algorithm = _algorithm_id(key.public_key_algorithm)
       length = _key_length(key)
       created = datetime.datetime.fromtimestamp(key.created_at, tz=datetime.UTC)
       if created > datetime.datetime(2026, 4, 1, 0, 0, 0, tzinfo=datetime.UTC):
           if algorithm not in _APPROVED_KEY_ALGORITHMS:
               raise ValueError(...)
           if (algorithm in _RSA_ALGORITHMS) and (length < _RSA_MINIMUM_BITS):
               raise ValueError(...)
           if (algorithm not in _RSA_ALGORITHMS) and (length < _EC_MINIMUM_BITS):
               raise ValueError(...)
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650#issuecomment-5933399057

   > For the newer keys, do you want to continue to enforce 4096 as we do now, or would you rather we downgrade that to a preference, as Infra state it?
   
   Let's continue to enforce 4096. Let's be sure to document this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg commented on issue #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650#issuecomment-5930432107

   | Column | Meaning |
     |---|---|
     | Still on weak key | Active projects whose newest release with a recorded signer was signed with a weak key |
     | Moved to strong key | Active projects which used a weak key before, but whose newest release with a recorded signer used a strong key |
     | Unknown signer since | Of the projects still on a weak key, those with a newer release that has no signer recorded, so they may have moved too |
     | Last weak signature (still-weak projects) | Most recent weak-signed release among the projects still on a weak key |
     | Last weak signature (any project) | Most recent weak-signed release in the PMC, including projects which have since moved |
   
     | PMC | Still on weak key | Moved to strong key | Unknown signer since | Last weak signature (still-weak projects) | Last weak signature (any project) |
     |---|--:|--:|--:|---|---|
     | maven | 2 | 49 | 1 | 2026-06-05 | 2026-06-05 |
     | httpcomponents | 3 | 1 | 1 | 2026-04-19 | 2026-04-19 |
     | pdfbox | 3 | 0 | 1 | 2026-03-12 | 2026-03-12 |
     | jspwiki | 1 | 0 | 1 | 2025-07-29 | 2025-07-29 |
     | roller | 1 | 0 | 1 | 2025-04-09 | 2025-04-09 |
     | ant | 3 | 1 | 2 | 2024-12-31 | 2024-12-31 |
     | commons | 5 | 25 | 1 | 2024-06-03 | 2024-06-03 |
     | db | 1 | 2 | 0 | 2023-10-22 | 2023-10-22 |
     | felix | 17 | 19 | 4 | 2023-05-02 | 2023-05-02 |
     | mina | 2 | 2 | 1 | 2022-11-09 | 2023-09-12 |
     | aries | 3 | 2 | 1 | 2022-05-04 | 2022-05-04 |
     | toree | 1 | 0 | 0 | 2022-02-16 | 2022-02-16 |
     | sling | 5 | 39 | 1 | 2021-12-21 | 2022-03-14 |
     | myfaces | 14 | 2 | 1 | 2017-07-26 | 2017-07-26 |
     | directory | 1 | 3 | 0 | 2015-08-16 | 2015-08-16 |
     | velocity | 3 | 2 | 0 | 2014-10-30 | 2020-07-06 |
     | xerces | 1 | 1 | 0 | 2014-10-30 | 2014-10-30 |
     | turbine | 2 | 3 | 0 | 2014-03-30 | 2020-07-03 |
     | tomcat | 1 | 2 | 0 | 2013-11-07 | 2018-04-27 |
     | axis | 1 | 1 | 0 | 2013-05-04 | 2013-05-04 |
     | sis | 1 | 1 | 1 | 2012-07-23 | 2013-08-07 |
     | jackrabbit | 2 | 2 | 0 | 2011-01-25 | 2020-07-03 |
     | james | 1 | 4 | 0 | 2010-05-27 | 2013-03-22 |
     | uima | 1 | 0 | 0 | 2010-01-26 | 2010-01-26 |
     | logging | 1 | 2 | 1 | 2009-12-12 | 2017-03-11 |
     | hadoop | 1 | 1 | 1 | 2007-12-30 | 2014-06-19 |
     | apr | 1 | 2 | 1 | 2005-03-17 | 2011-12-13 |
   
   Every recent weak signer (2023 onwards) is a DSA key, mostly 1024 bit, and in each case the weak key is the certificate's primary with no stronger signing subkey to fall back on. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg closed issue #1650: Survey key strength enforcement and grandfathered keys
URL: https://github.com/apache/tooling-trusted-releases/issues/1650


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650#issuecomment-5919978049

   The implication is that there are two validations for keys:
   
   1. The current one for imports of KEYS files.
   2. This new one for uploads of a user's key and the signature check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "alitheg (via GitHub)" <gi...@apache.org>.
alitheg commented on issue #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650#issuecomment-5929920489

   We implemented a hard enforcement for 4096 on new keys in #985 from an earlier ASVS audit. I'll implement the ban on <2048 being used now for all keys (regardless of age). For the newer keys, do you want to continue to enforce 4096 as we do now, or would you rather we downgrade that to a preference, as Infra state it @dave2wave?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Survey key strength enforcement and grandfathered keys (tooling-trusted-releases)

Posted by "dave2wave (via GitHub)" <gi...@apache.org>.
dave2wave commented on issue #1650:
URL: https://github.com/apache/tooling-trusted-releases/issues/1650#issuecomment-5919942707

   The reference is https://infra.apache.org/release-signing.html#note
   
   We should no longer allow keys that don't fit the minimum length of 2048 size and not RSA to sign releases. A Candidate signed with such a key should be blocked.
   
   The key upload form should make the preference for 4096 size and RSA clear.
   
   When a user uploads a key that is no longer a valid signature then we must reject it. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@tooling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org