You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by ta...@apache.org on 2017/11/23 04:19:27 UTC

[3/5] incubator-impala git commit: IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

IMPALA-2250: Make multiple COUNT(DISTINCT) message state workarounds

Change-Id: I5084be10946d68f3ec0760c2b7e698635df26a89
Reviewed-on: http://gerrit.cloudera.org:8080/8614
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins


Project: http://git-wip-us.apache.org/repos/asf/incubator-impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-impala/commit/3845c0f1
Tree: http://git-wip-us.apache.org/repos/asf/incubator-impala/tree/3845c0f1
Diff: http://git-wip-us.apache.org/repos/asf/incubator-impala/diff/3845c0f1

Branch: refs/heads/master
Commit: 3845c0f157e2ab2022dcf610a69c85abee9028ea
Parents: 21a96ed
Author: Jinchul <ji...@gmail.com>
Authored: Wed Nov 22 17:00:40 2017 +0900
Committer: Impala Public Jenkins <im...@gerrit.cloudera.org>
Committed: Thu Nov 23 00:21:30 2017 +0000

----------------------------------------------------------------------
 fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-impala/blob/3845c0f1/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
----------------------------------------------------------------------
diff --git a/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java b/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
index 2e142ff..39a28e8 100644
--- a/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
+++ b/fe/src/main/java/org/apache/impala/analysis/AggregateInfo.java
@@ -246,7 +246,10 @@ public class AggregateInfo extends AggregateInfoBase {
         throw new AnalysisException(
             "all DISTINCT aggregate functions need to have the same set of "
             + "parameters as " + distinctAggExprs.get(0).toSql()
-            + "; deviating function: " + distinctAggExprs.get(i).toSql());
+            + "; deviating function: " + distinctAggExprs.get(i).toSql() + "\n"
+            + "Consider using NDV() instead of COUNT(DISTINCT) if estimated "
+            + "counts are acceptable. Enable the APPX_COUNT_DISTINCT query "
+            + "option to perform this rewrite automatically.");
       }
     }