You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2022/06/29 23:52:02 UTC
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa opened a new pull request, #24: Added a simple fix for the Hashtag in a Namespace
schaefa opened a new pull request, #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24
I am no Javacc expert but that seems to do the trick.
I allow for an escaped hashtag inside a string and then replace \# with a # inside the RegisterNamespace operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on code in PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123
##########
src/test/resources/testcases/test-40-output.txt:
##########
@@ -1,3 +1,3 @@
RegisterNamespace (foo) uri:some-uri/V/1.0
RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
Review Comment:
~~The URI should be wrapped with quotes here in the output~~
Correction, this should not be wrapped in quotes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171744468
I updated the code to showcase the issue. I tried multiple things:
\#: fails the repo init parser test
\\#: fails the repo init parser test
\\\\#: fails the output and repo init parser test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #24: Added a simple fix for the Hashtag in a Namespace
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1170604233
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171763417
I did that but now the test fails because the hashtag went missing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on code in PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123
##########
src/test/resources/testcases/test-40-output.txt:
##########
@@ -1,3 +1,3 @@
RegisterNamespace (foo) uri:some-uri/V/1.0
RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
Review Comment:
The URI should be wrapped with quotes here in the output
##########
src/test/resources/testcases/test-40.txt:
##########
@@ -3,4 +3,4 @@
# and o.a.s.jcr.repoinit 1.0.2
register namespace (foo) uri:some-uri/V/1.0
register namespace ( prefix_with-other.things ) andSimpleURI
-register namespace (foo2) uri:some-uri/V/1.1/test\#
\ No newline at end of file
+register namespace (foo2) "uri:some-uri/V/1.1/test\\#"
Review Comment:
Should not need to escape the hash character here since the quotableString() doesn't need it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171837314
@enapps-enorman I used your suggestions but that requires the output to have quotes when it contains special character like the hashtag (RegisterNamespace (foo2) "uri:some-uri/V/1.1/test#") - I hope that works
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1172456228
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] bdelacretaz commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
bdelacretaz commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171374356
We already have a `quotableString()` production in the grammar, would it be an option to allow for quoting the namespace URI for such cases? The input would then be
register namespace (foo2) "uri:some-uri/V/1.1/test#"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171858959
> @enapps-enorman I used your suggestions but that requires the output to have quotes when it contains special character like the hashtag (RegisterNamespace (foo2) "uri:some-uri/V/1.1/test#") - I hope that works
I think that is because you have a change in RegisterNamespace#getParametersDescription that I did not have. To be honest, I'm not sure if quotes or no-quotes is correct in the "toString" output. It looked to me that other places were not using quotes in the "toString" output for their quotable strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] anchela commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
anchela commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1170878577
@schaefa , thanks for the patch. can you please ask @bdelacretaz for a review? i am busy and don't have time for a thorough review, while he is the author of repoinit and should have a say here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171735204
I tried that but I could not get the '#' in. Either it is ignored or I have '\#'. The quotedString() is not converting an escaped backslash. Even when I fix the conversion in the RegisterNamespace operation class I get a RepIniParsingException because it does not like the '\#' or '\\#'.
Any suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171766851
> I did that but now the test fails because the hashtag went missing
@schaefa Take a look at the what I stashed in my fork at: https://github.com/enapps-enorman/sling-org-apache-sling-repoinit-parser/commit/6d8a5401468d4965cc1726236dd7dac206df7cbc to see if that works for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] enapps-enorman commented on a diff in pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
enapps-enorman commented on code in PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#discussion_r911494123
##########
src/test/resources/testcases/test-40-output.txt:
##########
@@ -1,3 +1,3 @@
RegisterNamespace (foo) uri:some-uri/V/1.0
RegisterNamespace (prefix_with-other.things) andSimpleURI
-RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
+RegisterNamespace (foo2) uri:some-uri/V/1.1/test#
Review Comment:
~~The URI should be wrapped with quotes here in the output~~
Correction, this should not be wrapped in quotes as this is the output from RegisterNamespace#toString and not the output from RegisterNamespace#asRepoInitString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] sonarcloud[bot] commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1171838566
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list) [100.0% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-repoinit-parser&pullRequest=24&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa commented on pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa commented on PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24#issuecomment-1172456457
Yes, that fixed the issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-repoinit-parser] schaefa merged pull request #24: SLING-11427 : Registering a Namespace does not allow Hashtag in the URI
Posted by GitBox <gi...@apache.org>.
schaefa merged PR #24:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org