[GitHub] [pulsar] benstadin opened a new issue #4655: Build fails including Logger.h

[GitBox <gi...@apache.org>]

benstadin opened a new issue #4655: Build fails including Logger.h
URL: https://github.com/apache/pulsar/issues/4655
 
 
   Using Xcode / clang, the build fails when including Logger.h, because there is a log level named DEBUG (build error is "Expected identifier" because XCode defines a DEBUG macro per default for the debug target). Renaming it to e.g. TDEBUG fixes the issue:
   
   enum Level
       {
           TDEBUG = 0,
           INFO = 1,
           WARN = 2,
           ERROR = 3
       };
   
   IMHO, the best would be to avoid DEBUG and rename the enums to something like LOG_DEBUG, LOG_INFO etc. Even though it will mean a breaking change in some code. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services