You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by jun aoki <ju...@gmail.com> on 2013/01/10 02:42:45 UTC

Review Request: comma separated list in and for JavaActionExecutor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8915/
-----------------------------------------------------------

Review request for oozie.


Description
-------

comma separated list in <archive> and <file> for JavaActionExecutor


This addresses bug OOZIE-1153.
    https://issues.apache.org/jira/browse/OOZIE-1153


Diffs
-----

  http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1431169 
  http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1431169 

Diff: https://reviews.apache.org/r/8915/diff/


Testing
-------


Thanks,

jun aoki


Re: Review Request: comma separated list in and for JavaActionExecutor

Posted by jun aoki <ju...@gmail.com>.

> On Jan. 11, 2013, 1:25 a.m., Mona Chitnis wrote:
> > http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, line 481
> > <https://reviews.apache.org/r/8915/diff/1/?file=246032#file246032line481>
> >
> >     typo pathes. should be 'paths'

Mona, thank you for your comment. My bad. I will fix them when I add more tests for other actions, which was asked by Alejandro here 
https://issues.apache.org/jira/browse/OOZIE-1153?focusedCommentId=13550618&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13550618


- jun


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8915/#review15255
-----------------------------------------------------------


On Jan. 10, 2013, 1:42 a.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8915/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 1:42 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> comma separated list in <archive> and <file> for JavaActionExecutor
> 
> 
> This addresses bug OOZIE-1153.
>     https://issues.apache.org/jira/browse/OOZIE-1153
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1431169 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1431169 
> 
> Diff: https://reviews.apache.org/r/8915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jun aoki
> 
>


Re: Review Request: comma separated list in and for JavaActionExecutor

Posted by Mona Chitnis <mo...@yahoo.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8915/#review15255
-----------------------------------------------------------



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8915/#comment32925>

    typo pathes. should be 'paths'



http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
<https://reviews.apache.org/r/8915/#comment32926>

    same typo


- Mona Chitnis


On Jan. 10, 2013, 1:42 a.m., jun aoki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8915/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 1:42 a.m.)
> 
> 
> Review request for oozie.
> 
> 
> Description
> -------
> 
> comma separated list in <archive> and <file> for JavaActionExecutor
> 
> 
> This addresses bug OOZIE-1153.
>     https://issues.apache.org/jira/browse/OOZIE-1153
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1431169 
>   http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1431169 
> 
> Diff: https://reviews.apache.org/r/8915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> jun aoki
> 
>