You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by eribeiro <gi...@git.apache.org> on 2016/12/15 17:34:48 UTC
[GitHub] zookeeper pull request #126: ZOOKEEPER-2465: Documentation copyright notice ...
GitHub user eribeiro opened a pull request:
https://github.com/apache/zookeeper/pull/126
ZOOKEEPER-2465: Documentation copyright notice is out of date.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eribeiro/zookeeper ZOOKEEPER-2465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/126.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #126
----
commit fea03adb512a6414e5b8733416c4bc3ef202d2cc
Author: Edward Ribeiro <ed...@gmail.com>
Date: 2016-12-15T17:25:24Z
ZOOKEEPER-2465: Documentation copyright notice is out of date.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper pull request #126: ZOOKEEPER-2465: Documentation copyright notice ...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro closed the pull request at:
https://github.com/apache/zookeeper/pull/126
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/126
@cnauroth and @fpj, this patch applies cleanly for both branch-3.5 and master. I also re-generated the docs to see if the year interval was omitted.
PS: unfortunately, it doesn't apply to branch-3.4 due to many new features and changes, so let me know if you want a variation of this PR targeting branch-3.4 (still unsure how to do this).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/126
Done. \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/126
@eribeiro I am thinking we can just change src/docs/src/documentation/skinconf.xml and leave other files in your original patch intact. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/126
@eribeiro should we only change the document sources and generate the html/pdf in separate commit? There was a recent discussion on dev-list about this proposal and most folks leaning towards separation of doc source change and actual doc binary change. We can use ZOOKEEPER-2635 again before 3.5.3 release to regenerate everything.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/126
+1. Gonna change the PR. Thx!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #126: ZOOKEEPER-2465: Documentation copyright notice is out ...
Posted by eribeiro <gi...@git.apache.org>.
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/126
@hanm Hey Michael, I was absent last week so I delayed a bit to answer this question, excuse me.
Yup, I am aware of the discussion but I didn't have time to catch up with it until I leave for holidays (shame on me). What do you suggest is the best approach regarding this issue? I can close this PR, no problem. :smiley:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---