You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celeborn.apache.org by GitBox <gi...@apache.org> on 2022/11/29 07:13:30 UTC
[GitHub] [incubator-celeborn] AngersZhuuuu opened a new pull request, #1021: [CELEBORN-78][REFACTOR] Extract heartbearter from LifecycleManager
AngersZhuuuu opened a new pull request, #1021:
URL: https://github.com/apache/incubator-celeborn/pull/1021
### What changes were proposed in this pull request?
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### What are the items that need reviewer attention?
### Related issues.
### Related pull requests.
### How was this patch tested?
/cc @related-reviewer
/assign @main-reviewer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1021: [CELEBORN-78][REFACTOR] Extract heartbearter from LifecycleManager
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on code in PR #1021:
URL: https://github.com/apache/incubator-celeborn/pull/1021#discussion_r1034400223
##########
client/src/main/scala/org/apache/celeborn/client/Heartbeater.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.client
+
+import java.util.concurrent.{ScheduledFuture, TimeUnit}
+
+import scala.concurrent.duration.DurationInt
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.haclient.RssHARetryClient
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.protocol.message.ControlMessages.{HeartbeatFromApplication, ZERO_UUID}
+import org.apache.celeborn.common.util.ThreadUtils
+
+class Heartbeater(
Review Comment:
> appHeartBeater
Nice suggestion, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu commented on pull request #1021: [CELEBORN-78][REFACTOR] Extract heartbearter from LifecycleManager
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on PR #1021:
URL: https://github.com/apache/incubator-celeborn/pull/1021#issuecomment-1330187020
ping @FMX @RexXiong @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] FMX commented on a diff in pull request #1021: [CELEBORN-78][REFACTOR] Extract heartbearter from LifecycleManager
Posted by GitBox <gi...@apache.org>.
FMX commented on code in PR #1021:
URL: https://github.com/apache/incubator-celeborn/pull/1021#discussion_r1034385515
##########
client/src/main/scala/org/apache/celeborn/client/Heartbeater.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.celeborn.client
+
+import java.util.concurrent.{ScheduledFuture, TimeUnit}
+
+import scala.concurrent.duration.DurationInt
+
+import org.apache.celeborn.common.CelebornConf
+import org.apache.celeborn.common.haclient.RssHARetryClient
+import org.apache.celeborn.common.internal.Logging
+import org.apache.celeborn.common.protocol.message.ControlMessages.{HeartbeatFromApplication, ZERO_UUID}
+import org.apache.celeborn.common.util.ThreadUtils
+
+class Heartbeater(
Review Comment:
Shall we rename it to appHeartBeater? Because there will be a worker heartbeater.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-celeborn] AngersZhuuuu merged pull request #1021: [CELEBORN-78][REFACTOR] Extract heartbearter from LifecycleManager
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu merged PR #1021:
URL: https://github.com/apache/incubator-celeborn/pull/1021
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org