You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/09/07 03:44:51 UTC

[GitHub] [rocketmq-externals] ybonfire commented on issue #66: rocketmq-cpp/producer/tryToCompressMessage没有判断msg是否被压缩过

ybonfire commented on issue #66:
URL: https://github.com/apache/rocketmq-externals/issues/66#issuecomment-688011412


   > 
   > 
   > 看了下bugfix的代码[apache/rocketmq#294](https://github.com/apache/rocketmq/pull/294)，不太理解DefaultMQProducerImpl.sendKernelImpl在异步发送逻辑单独resetbody的原因，在大的try,catch,finally中不是已经resetbody，在异步发送的callback回调里再次使用改msg，应该不会是压缩后的吧
   
   是不是这段代码写错地方了。应该写在SYNC分支里？我感觉同步发送会产生重复压缩的问题


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org