You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/05/31 22:11:25 UTC
[GitHub] [spark] ajithme commented on a change in pull request #24762:
[SPARK-27907][SQL] HiveUDAF with 0 rows throw NPE
ajithme commented on a change in pull request #24762: [SPARK-27907][SQL] HiveUDAF with 0 rows throw NPE
URL: https://github.com/apache/spark/pull/24762#discussion_r289565476
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveUDAFSuite.scala
##########
@@ -149,6 +149,14 @@ class HiveUDAFSuite extends QueryTest with TestHiveSingleton with SQLTestUtils {
}
}
}
+
+ test("HiveUDAF with 0 rows throws NPE") {
+ sql("create table abc(a int)")
+ sql("select histogram_numeric(a,2) from abc").show
Review comment:
Agreed. Updated the testcases to do ``checkAnswer``
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org