You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/01 15:19:50 UTC

[GitHub] cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example

cjolivier01 commented on a change in pull request #9799: Cleaned up image classification cpp example
URL: https://github.com/apache/incubator-mxnet/pull/9799#discussion_r171591209
 
 

 ##########
 File path: example/image-classification/predict-cpp/CMakeLists.txt
 ##########
 @@ -1,34 +1,28 @@
-if(USE_OPENCV)
-  find_package(OpenCV QUIET COMPONENTS core highgui imgproc imgcodecs)
-  if(NOT OpenCV_FOUND) # if not OpenCV 3.x, then imgcodecs are not found
-    find_package(OpenCV REQUIRED COMPONENTS core highgui imgproc)
-  endif()
-
-  if(NOT MSVC)
-    set(UNITTEST_STATIC_LINK ON)
-  endif()
+# ---[ OpenCV
+if(NOT USE_OPENCV OR NOT OpenCV_FOUND)
+  message(WARNING "\
+OpenCV should be enabled and found to build image classification example, skipping...")
 
 Review comment:
   isn?t the unittest static link flag removed?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services