You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "gamemerlin (via GitHub)" <gi...@apache.org> on 2025/04/24 15:51:37 UTC
[PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
gamemerlin opened a new pull request, #9900:
URL: https://github.com/apache/nifi/pull/9900
# Summary
[NIFI-14402](https://issues.apache.org/jira/browse/NIFI-14402) - simply enable / disabling message for activating ports
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Manual
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on code in PR #9900:
URL: https://github.com/apache/nifi/pull/9900#discussion_r2061317306
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -219,7 +219,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
<button mat-menu-item (click)="toggleTransmission(port)">
<i
class="fa fa-bullseye transmitting primary-color mr-2"></i>
- Transmitting: click to toggle port transmission
+ Disable transmission
Review Comment:
Can we update the icon here as well? I think we're showing the opposite icon here. For instance when a component is Running and we present the Stop action we would show a Stop icon too. This menu item is to Disable the remote port so we should render the Disable icon.
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -228,7 +228,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
(click)="toggleTransmission(port)">
<i
class="not-transmitting icon icon-transmit-false primary-color mr-2"></i>
- Not Transmitting: click to toggle port transmission
+ Enable transmission
Review Comment:
Can we also swap this icon as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman merged PR #9900:
URL: https://github.com/apache/nifi/pull/9900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
Posted by "gamemerlin (via GitHub)" <gi...@apache.org>.
gamemerlin commented on code in PR #9900:
URL: https://github.com/apache/nifi/pull/9900#discussion_r2061547335
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -219,7 +219,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
<button mat-menu-item (click)="toggleTransmission(port)">
<i
class="fa fa-bullseye transmitting primary-color mr-2"></i>
- Transmitting: click to toggle port transmission
+ Disable transmission
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
Posted by "gamemerlin (via GitHub)" <gi...@apache.org>.
gamemerlin commented on code in PR #9900:
URL: https://github.com/apache/nifi/pull/9900#discussion_r2061547388
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/manage-remote-ports/manage-remote-ports.component.html:
##########
@@ -228,7 +228,7 @@ <h3 class="primary-color">Manage Remote Ports</h3>
(click)="toggleTransmission(port)">
<i
class="not-transmitting icon icon-transmit-false primary-color mr-2"></i>
- Not Transmitting: click to toggle port transmission
+ Enable transmission
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] NIFI-14402 manage remote ports -> action menu, update labels for enabling ports [nifi]
Posted by "mcgilman (via GitHub)" <gi...@apache.org>.
mcgilman commented on PR #9900:
URL: https://github.com/apache/nifi/pull/9900#issuecomment-2832208838
Reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org