[GitHub] [incubator-kvrocks] PragmaTwice commented on a diff in pull request #991: Change server redis version string

[GitBox <gi...@apache.org>]

PragmaTwice commented on code in PR #991:
URL: https://github.com/apache/incubator-kvrocks/pull/991#discussion_r996249328


##########
src/server.cc:
##########
@@ -780,7 +780,7 @@ void Server::GetServerInfo(std::string *info) {
   }
   time(&now);
   string_stream << "# Server\r\n";
-  string_stream << "version:" << VERSION << "\r\n";
+  string_stream << "redis_version:" << VERSION << "\r\n";

Review Comment:
   I think if we need a `redis_version` in server info, maybe we need to select a real redis version rather than kvrocks version.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org