You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@river.apache.org by Patricia Shanahan <pa...@acm.org> on 2010/08/29 07:34:45 UTC
Question about JIRA use
In reading SDM source code, I've found a possible scaling performance
problem in the method findReg. Whether it is really a problem depends on
how many lookup services an SDM may know about at one time. I don't
intend to investigate that right now - I've got too many things going on
already.
One way to remember something like this would be to write a JIRA issue
about it. Is that the best way?
Patricia
Re: Question about JIRA use
Posted by Benson Margulies <bi...@gmail.com>.
Yes, there's no tax on JIRA.
On Sun, Aug 29, 2010 at 6:14 AM, Jonathan Costers
<jo...@googlemail.com> wrote:
> Hi Patricia - I think you uncovered a subtle bug so yes, JIRA would be the
> place to log such things.
> We probably also want to log issues for any failing QA tests, to keep these
> on the radar ...
> Thanks
> Jonathan
>
> 2010/8/29 Craig L Russell <cr...@oracle.com>
>
>> Hi Patricia,
>>
>>
>> On Aug 28, 2010, at 10:34 PM, Patricia Shanahan wrote:
>>
>> In reading SDM source code, I've found a possible scaling performance
>>> problem in the method findReg. Whether it is really a problem depends on how
>>> many lookup services an SDM may know about at one time. I don't intend to
>>> investigate that right now - I've got too many things going on already.
>>>
>>> One way to remember something like this would be to write a JIRA issue
>>> about it. Is that the best way?
>>>
>>
>> It is a "permanent" record, and there's nothing against having lots of
>> issues in the system. I'd say go for it.
>>
>> Craig
>>
>>>
>>> Patricia
>>>
>>
>> Craig L Russell
>> Assistant Secretary, Apache Software Foundation
>> Chair, OpenJPA PMC
>> clr@apache.org http://db.apache.org/jdo
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
Re: Question about JIRA use
Posted by Jonathan Costers <jo...@googlemail.com>.
Hi Patricia - I think you uncovered a subtle bug so yes, JIRA would be the
place to log such things.
We probably also want to log issues for any failing QA tests, to keep these
on the radar ...
Thanks
Jonathan
2010/8/29 Craig L Russell <cr...@oracle.com>
> Hi Patricia,
>
>
> On Aug 28, 2010, at 10:34 PM, Patricia Shanahan wrote:
>
> In reading SDM source code, I've found a possible scaling performance
>> problem in the method findReg. Whether it is really a problem depends on how
>> many lookup services an SDM may know about at one time. I don't intend to
>> investigate that right now - I've got too many things going on already.
>>
>> One way to remember something like this would be to write a JIRA issue
>> about it. Is that the best way?
>>
>
> It is a "permanent" record, and there's nothing against having lots of
> issues in the system. I'd say go for it.
>
> Craig
>
>>
>> Patricia
>>
>
> Craig L Russell
> Assistant Secretary, Apache Software Foundation
> Chair, OpenJPA PMC
> clr@apache.org http://db.apache.org/jdo
>
>
>
>
>
>
>
>
>
Re: Question about JIRA use
Posted by Craig L Russell <cr...@oracle.com>.
Hi Patricia,
On Aug 28, 2010, at 10:34 PM, Patricia Shanahan wrote:
> In reading SDM source code, I've found a possible scaling
> performance problem in the method findReg. Whether it is really a
> problem depends on how many lookup services an SDM may know about at
> one time. I don't intend to investigate that right now - I've got
> too many things going on already.
>
> One way to remember something like this would be to write a JIRA
> issue about it. Is that the best way?
It is a "permanent" record, and there's nothing against having lots of
issues in the system. I'd say go for it.
Craig
>
> Patricia
Craig L Russell
Assistant Secretary, Apache Software Foundation
Chair, OpenJPA PMC
clr@apache.org http://db.apache.org/jdo
Re: Question about JIRA use
Posted by Patricia Shanahan <pa...@acm.org>.
On 8/29/2010 1:45 PM, Peter Firmstone wrote:
> We've got MultithreadedTC in the test/lib directory for allows for
> specific interleaving of threads to test concurrency issues.
>
> http://www.cs.umd.edu/projects/PL/multithreadedtc/overview.html
Very, very interesting. One of my projects is an attempt to wrap a
ServiceDiscoveryManager in stub versions of the classes with which it
interacts, so that I can force lots of events to happen as close as
possible to the same time. That library might make it possible to force
specific test cases.
I want to do the same to JoinManager, especially so that I can force
retries, which do not seem to be being tested.
>
> Probably best wait till I've got the bug sorted though.
>
> An update on progress:
>
> It appears I've sorted the Null pointer issue and the Serialization
> issue, so I'm no longer getting exceptions, however I'm still getting
> test failures, in the ServiceDiscoveryManager, which appear related to
> timing issues, counting events etc.
>
> I integrated Brian's patch, but that fix isn't related to this
> particular case.
>
> The next step over the coming week, will be to go back to the stable
> build and incrementally add recent changes, including those I have
> locally now, so I can pinpoint problem causes.
One of the unfortunate things about timing problems is that a perfectly
valid change can unmask a latent concurrency bug. That is why I've held
off on pushing a new TaskManager while I'm unsure about the correctness
of SDM and JoinManager's use of TaskManager.
> Did you want me to update my current local changes to SVN? I've been
> holding off, since additional changes that haven't solved the problem,
> won't make the problem any clearer to those trying to solve it.
If you have fixes for problems you do understand, I would vote for
checking them in.
Patricia
Re: Question about JIRA use
Posted by Peter Firmstone <ji...@zeus.net.au>.
We've got MultithreadedTC in the test/lib directory for allows for
specific interleaving of threads to test concurrency issues.
http://www.cs.umd.edu/projects/PL/multithreadedtc/overview.html
Probably best wait till I've got the bug sorted though.
An update on progress:
It appears I've sorted the Null pointer issue and the Serialization
issue, so I'm no longer getting exceptions, however I'm still getting
test failures, in the ServiceDiscoveryManager, which appear related to
timing issues, counting events etc.
I integrated Brian's patch, but that fix isn't related to this
particular case.
The next step over the coming week, will be to go back to the stable
build and incrementally add recent changes, including those I have
locally now, so I can pinpoint problem causes.
Did you want me to update my current local changes to SVN? I've been
holding off, since additional changes that haven't solved the problem,
won't make the problem any clearer to those trying to solve it.
Cheers,
Peter.
Patricia Shanahan wrote:
> In reading SDM source code, I've found a possible scaling performance
> problem in the method findReg. Whether it is really a problem depends
> on how many lookup services an SDM may know about at one time. I don't
> intend to investigate that right now - I've got too many things going
> on already.
>
> One way to remember something like this would be to write a JIRA issue
> about it. Is that the best way?
>
> Patricia
>