[GitHub] [incubator-doris] WingsGo edited a comment on pull request #3986: [Config]Allower use to config different thrift server model

[GitBox <gi...@apache.org>]

WingsGo edited a comment on pull request #3986:
URL: https://github.com/apache/incubator-doris/pull/3986#issuecomment-651743033


   > Better to use a `string` instead of `int` type of this config.
   > And TSimpleServer seems unnecessary.
   
   use string is better and easy to understand, but Config have no check logic, we can only set default server model when use have typo error like `Threadd`,In this case, user may think they use a `Threaded` server model, but it is not what he think, use int type is to avoid situation like this. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org