You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/07/01 02:46:47 UTC
[jira] Created: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
patchJavacWarnings and trunkJavacWarnings are not consistent.
-------------------------------------------------------------
Key: HADOOP-6124
URL: https://issues.apache.org/jira/browse/HADOOP-6124
Project: Hadoop Common
Issue Type: Bug
Components: build
Reporter: Tsz Wo (Nicholas), SZE
The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6124:
-------------------------------------------
Hadoop Flags: [Reviewed]
If the patch works for you, it may work for Hudson. Let's give it a try.
+1 Patch looks good.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739090#action_12739090 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6124:
------------------------------------------------
Script testing is not yet supported (see HADOOP-6174). So I am going to commit this without submitting to Hudson.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739431#action_12739431 ]
Hudson commented on HADOOP-6124:
--------------------------------
Integrated in Hadoop-Common-trunk #45 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/45/])
. Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6124:
-------------------------------------------
Priority: Critical (was: Major)
Hope this can be fixed soon. Otherwise, patches with javac warnings may get in without being noticed. Changed the priority to "critical".
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Giridharan Kesavan updated HADOOP-6124:
---------------------------------------
Attachment: HADOOP-6124.patch
this patch adds the clean target before calling the tar while searching for javac warnings and also address the issue mentioned as part of HADOOP-6077.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Giridharan Kesavan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738791#action_12738791 ]
Giridharan Kesavan commented on HADOOP-6124:
--------------------------------------------
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] -1 javac. The applied patch generated 100 javac compiler warnings (more than the trunk's current 99 warnings).
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
applied the hadoop-6124.patch and tested a hadoop patch that introduced a javac warning. Here is the result.
test-patch was able to parse and show the increase in the no of javac warnings.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734250#action_12734250 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6124:
------------------------------------------------
Quite a few javac warnings are getting in without being detected. See MAPREDUCE-716 and MAPREDUCE-743.
Giridharan, if you are not going to work on this soon, please un-assign yourself. Someone else may want to work on this.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-6124:
-------------------------------------------
Attachment: c6124_20090701.patch
> ... HDFS and MapReduce seem not having this problem.
I was wrong. HDFS and MapReduce also have this problem.
The project is not cleaned when patchJavacWarnings.txt is generated. Some java source files may be already compiled and they will not be compiled again. As a result, the warnings inside those files won't be reported. Note that there is a clean when trunkJavacWarnings.txt is generated.
c6124_20090701.patch: add clean before tar
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: c6124_20090701.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739461#action_12739461 ]
Hudson commented on HADOOP-6124:
--------------------------------
Integrated in Hadoop-Hdfs-trunk #40 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk/40/])
. Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735189#action_12735189 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6124:
------------------------------------------------
HADOOP-6124.patch has some good changes for HADOOP-6077 but it did not fix the problem in this issue.
{noformat}
[exec] There appear to be 122 javac compiler warnings before the patch and
64 javac compiler warnings after applying the patch.
{noformat}
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12726673#action_12726673 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-6124:
------------------------------------------------
Giridharan, c6124_20090701.patch does not fix the entire problem. There are still some additional bugs in test-patch.sh. Since you are the assignee, I will leave this issue to you. Thanks for working on this.
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Attachments: c6124_20090701.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739574#action_12739574 ]
Hudson commented on HADOOP-6124:
--------------------------------
Integrated in Hadoop-Mapreduce-trunk #39 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Mapreduce-trunk/39/])
. Fix javac warning detection in test-patch.sh. Contributed by Giridharan Kesavan
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley reassigned HADOOP-6124:
-----------------------------------
Assignee: Giridharan Kesavan
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Attachments: c6124_20090701.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-6124) patchJavacWarnings and
trunkJavacWarnings are not consistent.
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-6124.
--------------------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
I have committed this. Thanks, Giridharan!
> patchJavacWarnings and trunkJavacWarnings are not consistent.
> -------------------------------------------------------------
>
> Key: HADOOP-6124
> URL: https://issues.apache.org/jira/browse/HADOOP-6124
> Project: Hadoop Common
> Issue Type: Bug
> Components: build
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Giridharan Kesavan
> Priority: Critical
> Fix For: 0.21.0
>
> Attachments: c6124_20090701.patch, HADOOP-6124.patch
>
>
> The values of patchJavacWarnings and trunkJavacWarnings are not consistent when running test-patch.sh with an empty patch over Common. HDFS and MapReduce seem not having this problem.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.