[jira] [Commented] (HADOOP-11161) Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources

["Aaron T. Myers (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-11161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14158129#comment-14158129 ] 

Aaron T. Myers commented on HADOOP-11161:
-----------------------------------------

Makes sense, and the patch looks good to me. +1 pending Jenkins.

Thanks, Arun.

> Expose close method in KeyProvider to give clients of Provider implementations a hook to release resources
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-11161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-11161
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Arun Suresh
>            Assignee: Arun Suresh
>         Attachments: HADOOP-11161.1.patch
>
>
> The {{KMSClientProvider}} class needs to be have a {{close()}} method to shutdown back ground executor threads.
> The {{DFSClient}} creates an instance of a {{KeyProvider}} during initialization. If this KP is a {{KMSClientProvider}}, this needs to be closed to prevent thread leakage



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)