You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/10/04 06:02:56 UTC

[GitHub] [incubator-pinot] jackjlli opened a new pull request #4678: Use guava cache for instance admin endpoints

jackjlli opened a new pull request #4678: Use guava cache for instance admin endpoints
URL: https://github.com/apache/incubator-pinot/pull/4678
 
 
   This PR:
   * uses guava cache for instance admin endpoints.
   * removes cached data accessor, which comes from Helix code.
   
   Current usage of cached based data accessor has the issue described in this link: #4665
   And the cached data accessor was to solve the problem of frequent zk access to get the instance admin endpoints when there's segment upload. Plus, we've seen some flaky tests in our build, which are also related to this cached data accessor.
   This issue can be solved by just introducing a guava cache to cache the instance admin endpoint. So no need to maintain a cached data accessor any more.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org