You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/06/24 11:23:36 UTC

[commons-beanutils] branch master updated: This test fails on GH Java 11 but passes for me.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git


The following commit(s) were added to refs/heads/master by this push:
     new 06690791 This test fails on GH Java 11 but passes for me.
06690791 is described below

commit 06690791c8c3f5fc9ee65e8417cf3a6538d3e32f
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jun 24 07:23:32 2023 -0400

    This test fails on GH Java 11 but passes for me.
    
    Trying to fix.
---
 pom.xml                                                              | 5 +++++
 .../java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java     | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/pom.xml b/pom.xml
index 18e7bbdc..c223d972 100644
--- a/pom.xml
+++ b/pom.xml
@@ -333,6 +333,11 @@
       <artifactId>commons-logging</artifactId>
       <version>1.2</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.commons</groupId>
+      <artifactId>commons-lang3</artifactId>
+      <version>3.12.0</version>
+    </dependency>
     <dependency>
       <groupId>commons-collections</groupId>
       <artifactId>commons-collections-testframework</artifactId>
diff --git a/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java b/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java
index e8091e82..abf31bf0 100644
--- a/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java
+++ b/src/test/java/org/apache/commons/beanutils2/ConvertUtilsTestCase.java
@@ -25,6 +25,7 @@ import java.text.SimpleDateFormat;
 import java.util.Locale;
 
 import org.apache.commons.beanutils2.converters.DateConverter;
+import org.apache.commons.lang3.ArrayUtils;
 
 import junit.framework.Test;
 import junit.framework.TestCase;
@@ -314,7 +315,7 @@ public class ConvertUtilsTestCase extends TestCase {
 
         final String[] values1 = { "10", "20", "30" };
         Object value = ConvertUtils.convert(values1, Integer.TYPE);
-        final int[] shape = {};
+        final int[] shape = ArrayUtils.EMPTY_INT_ARRAY;
         assertEquals(shape.getClass(), value.getClass());
         final int[] results1 = (int[]) value;
         assertEquals(results1[0], 10);