You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/01/05 02:21:08 UTC

[GitHub] [hbase] leyangyueshan commented on pull request #2842: HBASE-25459 WAL can't be cleaned with phoenix5

leyangyueshan commented on pull request #2842:
URL: https://github.com/apache/hbase/pull/2842#issuecomment-754342388


   > I don't think we should add logic dealing with the specifics of a 3rd party project (phoenix) into hbase wal handling.
   > 
   > What about changing HBase WALFactory to allow pluggable custom wal providers implementations? Then this phoenix specific logic could be implemented on a Phoenix wal provider, keeping hbase agnostic to phoenix. AbstractFSWALProvider/WALProvider interfaces are all marked as IA Private, though, so it would be challenging maintain compatibility of custom wal providers.
   
   
   I think you are right! I will close this pr!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org