You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/02/19 01:06:26 UTC

[GitHub] cherrylzhao opened a new issue #1877: SQLStatement cache for parser-engine should not be a singleton object

cherrylzhao opened a new issue #1877: SQLStatement cache for parser-engine should not be a singleton object
URL: https://github.com/apache/incubator-shardingsphere/issues/1877
 
 
   we have used a singleton `ParsingResultCache` which key is prepared logic-sql to cache the SQLStatement. if the sharding-rule of the logic-sql have changed, or access the same logic-sql from multi-sharding-datasources, we will get an unexpected SQLStatement which sharding-condition is wrong. so we should cache the parsed SQLStatement within lifecycle of `ShardingContext`.
   
   - [ ] Make ParsingResultCache multi-instances available
   - [ ] Using ParsingResultCache in ShardingContext

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services